You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/26 06:23:16 UTC

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #674: bug: When k8s service is deleted, the APISIX Upstream nodes field is not cleared

tao12345666333 commented on issue #674:
URL: https://github.com/apache/apisix-ingress-controller/issues/674#issuecomment-1138198838

   @AlinsRan thanks.
   
   Currently we use the following methods to generate the upstream name. 
   https://github.com/apache/apisix-ingress-controller/blob/49dd015085a68ce4c26ba60076ef281ed71af2aa/pkg/types/apisix/v1/types.go#L425-L450
   
   Then generate its ID.
   https://github.com/apache/apisix-ingress-controller/blob/49dd015085a68ce4c26ba60076ef281ed71af2aa/pkg/id/idgen.go#L25-L39
   
   Maintaining the mapping relationship between Service and Upstream, I think it is a better choice. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org