You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2024/01/10 00:43:22 UTC

[PR] [MINOR] Add license header at docs/_plugins [spark]

HyukjinKwon opened a new pull request, #44647:
URL: https://github.com/apache/spark/pull/44647

   ### What changes were proposed in this pull request?
   
   This PR adds license header to `docs/_plugins` files.
   
   ### Why are the changes needed?
   
   To comply Apache License 2.0
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, dev-only.
   
   ### How was this patch tested?
   
   Existing CI should verify it e.g., linter.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [MINOR][DOCS] Add license header at docs/_plugins [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #44647: [MINOR][DOCS] Add license header at docs/_plugins
URL: https://github.com/apache/spark/pull/44647


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [MINOR][DOCS] Add license header at docs/_plugins [spark]

Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #44647:
URL: https://github.com/apache/spark/pull/44647#issuecomment-1891348109

   Should we update the RAT excludes?
   
   https://github.com/apache/spark/blob/c0ff0f579daa21dcc6004058537d275a0dd2920f/dev/.rat-excludes#L20
   
   I believe this is why the build did not catch these missing licenses. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [MINOR][DOCS] Add license header at docs/_plugins [spark]

Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #44647:
URL: https://github.com/apache/spark/pull/44647#issuecomment-1892653587

   FYI - I am checking upstream with the RAT devs to see if we can improve how the tool works. Having RAT scan `docs/` triggers a lot of spurious failures that are tedious to sort out.
   
   Because we use the CLI and not the Maven plugin (some [history here][1]), RAT does not automatically look at our `.gitignore` files. And the RAT exclude file patterns are regular expressions and not wildcard expressions, which I find confusing. (I think I am not alone on this point, judging from some of the lines in `.rat-excludes`.)
   
   I am following [RAT-323][r1] and [RAT-352][r2] to see if RAT will get some usability improvements for the CLI in the near future.
   
   [1]: https://github.com/apache/spark/pull/125#issuecomment-37327013
   [r1]: https://issues.apache.org/jira/browse/RAT-323
   [r2]: https://issues.apache.org/jira/browse/RAT-352


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [MINOR][DOCS] Add license header at docs/_plugins [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44647:
URL: https://github.com/apache/spark/pull/44647#issuecomment-1891372675

   I think we should probably update.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org