[GitHub] [flink] fapaul commented on a change in pull request #18838: [FLINK-26177][Connector/pulsar] Use testcontainer pulsar runtime instead o…

[GitBox <gi...@apache.org>]

fapaul commented on a change in pull request #18838:
URL: https://github.com/apache/flink/pull/18838#discussion_r820589407



##########
File path: flink-connectors/flink-connector-pulsar/archunit-violations/stored.rules
##########
@@ -0,0 +1,4 @@
+#
+#Thu Mar 03 12:42:13 CST 2022
+Tests\ inheriting\ from\ AbstractTestBase\ should\ have\ name\ ending\ with\ ITCase=3ac3a1dc-681f-4213-9990-b7b3298a20bc

Review comment:
       Do you know why this references an empty file? @JingGe 

##########
File path: flink-connectors/flink-connector-pulsar/archunit-violations/stored.rules
##########
@@ -0,0 +1,4 @@
+#
+#Thu Mar 03 12:42:13 CST 2022
+Tests\ inheriting\ from\ AbstractTestBase\ should\ have\ name\ ending\ with\ ITCase=3ac3a1dc-681f-4213-9990-b7b3298a20bc
+ITCASE\ tests\ should\ use\ a\ MiniCluster\ resource\ or\ extension=f4d91193-72ba-4ce4-ad83-98f780dce581

Review comment:
       I think the problem right now is that we need to add a custom rule for tests extending `SourceTestSuiteBase` and white list them. Can you open a ticket for that? @JingGe 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org