You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@bahir.apache.org by GitBox <gi...@apache.org> on 2019/06/07 14:16:28 UTC

[GitHub] [bahir-flink] liketic commented on a change in pull request #57: [BAHIR-205] Support configure password for redis cluster

liketic commented on a change in pull request #57: [BAHIR-205] Support configure password for redis cluster
URL: https://github.com/apache/bahir-flink/pull/57#discussion_r291611667
 
 

 ##########
 File path: flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/common/config/JedisClusterConfigTest.java
 ##########
 @@ -46,4 +48,20 @@ public void shouldThrowIllegalArgumentExceptionIfNodeValuesAreEmpty(){
             .setNodes(set)
             .build();
     }
+
+    @Test
+    public void shouldSetPasswordSuccessfully() {
 
 Review comment:
   I added the test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services