[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2472: [Engine][ResourceManager] Add ResourceManager

[GitBox <gi...@apache.org>]

ashulin commented on code in PR #2472:
URL: https://github.com/apache/incubator-seatunnel/pull/2472#discussion_r957464081


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/operation/source/AssignSplitOperation.java:
##########
@@ -51,7 +51,7 @@ public void run() throws Exception {
         SeaTunnelServer server = getService();
         RetryUtils.retryWithException(() -> {
             SourceSeaTunnelTask<?, SplitT> task =
-                server.getTaskExecutionService().getExecutionContext(taskID.getTaskGroupID()).getTaskGroup()
+                server.getSlotService().getSlotContext(taskID.getSlotID()).getTaskExecutionService().getExecutionContext(taskID.getTaskGroupID()).getTaskGroup()
                     .getTask(taskID.getTaskID());

Review Comment:
   Can the encapsulation of the slot be improved? Hide details in TaskExecutionService, TaskID is unique for a job, slot-id and task-group-id can be hidden.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org