You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2014/04/28 19:16:01 UTC
Review Request 20783: Patch for KAFKA-1424
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20783/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1424
https://issues.apache.org/jira/browse/KAFKA-1424
Repository: kafka
Description
-------
waitUntilMetadataIsPropagated() needs to Wait until leader in the metadata cache is valid.
Diffs
-----
core/src/main/scala/kafka/server/MetadataCache.scala a8b7bf74c3630b13bc190f5f7c3d20c341c3d0af
core/src/test/scala/unit/kafka/admin/AdminTest.scala a8d92f678bed7cb36bb29bdeeb772782cc793466
core/src/test/scala/unit/kafka/utils/TestUtils.scala f5a7a5bd92202d805250d9356c8a4e89e6f18732
Diff: https://reviews.apache.org/r/20783/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 20783: Patch for KAFKA-1424
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20783/#review41611
-----------------------------------------------------------
Ship it!
Ship It!
- Guozhang Wang
On April 28, 2014, 5:24 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20783/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 5:24 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1424
> https://issues.apache.org/jira/browse/KAFKA-1424
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Rename getPartitionInfos() to getPartitionInfo().
>
>
> waitUntilMetadataIsPropagated() needs to Wait until leader in the metadata cache is valid.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/MetadataCache.scala a8b7bf74c3630b13bc190f5f7c3d20c341c3d0af
> core/src/test/scala/unit/kafka/admin/AdminTest.scala a8d92f678bed7cb36bb29bdeeb772782cc793466
> core/src/test/scala/unit/kafka/utils/TestUtils.scala f5a7a5bd92202d805250d9356c8a4e89e6f18732
>
> Diff: https://reviews.apache.org/r/20783/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 20783: Patch for KAFKA-1424
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20783/#review41627
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On April 28, 2014, 5:24 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20783/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 5:24 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1424
> https://issues.apache.org/jira/browse/KAFKA-1424
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Rename getPartitionInfos() to getPartitionInfo().
>
>
> waitUntilMetadataIsPropagated() needs to Wait until leader in the metadata cache is valid.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/MetadataCache.scala a8b7bf74c3630b13bc190f5f7c3d20c341c3d0af
> core/src/test/scala/unit/kafka/admin/AdminTest.scala a8d92f678bed7cb36bb29bdeeb772782cc793466
> core/src/test/scala/unit/kafka/utils/TestUtils.scala f5a7a5bd92202d805250d9356c8a4e89e6f18732
>
> Diff: https://reviews.apache.org/r/20783/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 20783: Patch for KAFKA-1424
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20783/
-----------------------------------------------------------
(Updated April 28, 2014, 5:24 p.m.)
Review request for kafka.
Bugs: KAFKA-1424
https://issues.apache.org/jira/browse/KAFKA-1424
Repository: kafka
Description (updated)
-------
Rename getPartitionInfos() to getPartitionInfo().
waitUntilMetadataIsPropagated() needs to Wait until leader in the metadata cache is valid.
Diffs (updated)
-----
core/src/main/scala/kafka/server/MetadataCache.scala a8b7bf74c3630b13bc190f5f7c3d20c341c3d0af
core/src/test/scala/unit/kafka/admin/AdminTest.scala a8d92f678bed7cb36bb29bdeeb772782cc793466
core/src/test/scala/unit/kafka/utils/TestUtils.scala f5a7a5bd92202d805250d9356c8a4e89e6f18732
Diff: https://reviews.apache.org/r/20783/diff/
Testing
-------
Thanks,
Jun Rao