[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #527: [SpotBugs] Fix REC_CATCH_EXCEPTION

["kaijchen (via GitHub)" <gi...@apache.org>]

kaijchen commented on code in PR #527:
URL: https://github.com/apache/incubator-uniffle/pull/527#discussion_r1092695172


##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/LocalFileWriteHandler.java:
##########
@@ -52,17 +52,11 @@ public LocalFileWriteHandler(
 
   private void createBasePath() {
     File baseFolder = new File(basePath);
-    // check if shuffle folder exist
-    if (!baseFolder.exists()) {
-      try {
-        // try to create folder, it may be created by other Shuffle Server
-        baseFolder.mkdirs();
-      } catch (Exception e) {
-        // if folder exist, ignore the exception
-        if (!baseFolder.exists()) {
-          LOG.error("Can't create shuffle folder:" + basePath, e);
-          throw e;
-        }
+    // try to create folder, it may already exist
+    if (!baseFolder.isDirectory() && !baseFolder.mkdirs()) {
+      // if folder is not created successfully, make sure it exists
+      if (!baseFolder.isDirectory()) {
+        LOG.error("Can't create shuffle folder: {}", basePath);

Review Comment:
   After a second thought, let's just focus on spotbug issues in this PR.
   The `createBasePath()` can be fixed in another PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org