You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by "juergbi (via GitHub)" <gi...@apache.org> on 2025/01/24 10:26:52 UTC
[PR] Support gRPC connection options for retry and timeout [buildstream]
juergbi opened a new pull request, #1987:
URL: https://github.com/apache/buildstream/pull/1987
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support gRPC connection options for retry and timeout [buildstream]
Posted by "nanonyme (via GitHub)" <gi...@apache.org>.
nanonyme commented on PR #1987:
URL: https://github.com/apache/buildstream/pull/1987#issuecomment-2613509743
Looks more or less reasonable to me. The mypy change doesn't look related to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support gRPC connection options for retry and timeout [buildstream]
Posted by "juergbi (via GitHub)" <gi...@apache.org>.
juergbi commented on code in PR #1987:
URL: https://github.com/apache/buildstream/pull/1987#discussion_r2015773215
##########
doc/source/using_config.rst:
##########
@@ -145,6 +145,9 @@ toplevel of your configuration file, like so:
# are used.
connection-config:
keepalive-time: 60
+ retry-limit: 4
+ retry-delay: 1000
+ request-timeout: 300
Review Comment:
I've improved the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support gRPC connection options for retry and timeout [buildstream]
Posted by "abderrahim (via GitHub)" <gi...@apache.org>.
abderrahim commented on code in PR #1987:
URL: https://github.com/apache/buildstream/pull/1987#discussion_r2013923916
##########
doc/source/using_config.rst:
##########
@@ -145,6 +145,9 @@ toplevel of your configuration file, like so:
# are used.
connection-config:
keepalive-time: 60
+ retry-limit: 4
+ retry-delay: 1000
+ request-timeout: 300
Review Comment:
It would be a good idea to document the units given that retry-delay is in milliseconds while the other durations are in seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support gRPC connection options for retry and timeout [buildstream]
Posted by "juergbi (via GitHub)" <gi...@apache.org>.
juergbi merged PR #1987:
URL: https://github.com/apache/buildstream/pull/1987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support gRPC connection options for retry and timeout [buildstream]
Posted by "juergbi (via GitHub)" <gi...@apache.org>.
juergbi commented on PR #1987:
URL: https://github.com/apache/buildstream/pull/1987#issuecomment-2705872279
> Looks more or less reasonable to me. The mypy failure doesn't look related to this PR?
It was related to the regeneration of protobuf code with updated tooling. Fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org