You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Quantum0uasar (via GitHub)" <gi...@apache.org> on 2026/05/21 03:03:14 UTC

Re: [I] Extract shared request handlers from supervisor _handle_request methods [airflow]

Quantum0uasar commented on issue #65570:
URL: https://github.com/apache/airflow/issues/65570#issuecomment-4504401089

   Hi! I'd love to help with this refactoring effort.
   
   My understanding of the task:
   - Extract duplicated `_handle_request` handler logic from `ActivitySubprocess`, `CallbackSubprocess`, `TriggerRunnerSupervisor`, and `DagFileProcessorProcess` into shared handlers in `request_handlers.py`
   - Follow the pattern already established in `task-sdk/src/airflow/sdk/execution_time/request_handlers.py`
   
   I'll start by:
   1. Auditing the if/elif chains in each supervisor's `_handle_request` to identify common patterns
   2. Creating appropriate handler functions or a dispatch table in a shared module
   3. Updating the supervisors to call the shared handlers
   
   Would this be best done incrementally (one supervisor at a time) or all at once? Happy to open a draft PR with the first supervisor extracted to get early feedback!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org