You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by ae...@apache.org on 2018/04/19 03:23:20 UTC
[08/28] hadoop git commit: HDFS-13435. RBF: Improve the error
loggings for printing the stack trace.
HDFS-13435. RBF: Improve the error loggings for printing the stack trace.
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/c4d3636c
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/c4d3636c
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/c4d3636c
Branch: refs/heads/HDFS-7240
Commit: c4d3636c21acaeb2b7d56d19cd4996aa25151bd1
Parents: f1461b2
Author: Yiqun Lin <yq...@apache.org>
Authored: Tue Apr 17 11:23:22 2018 +0800
Committer: Yiqun Lin <yq...@apache.org>
Committed: Tue Apr 17 11:23:22 2018 +0800
----------------------------------------------------------------------
.../hdfs/server/federation/metrics/FederationMetrics.java | 2 +-
.../hdfs/server/federation/resolver/order/LocalResolver.java | 3 +--
.../hdfs/server/federation/router/RouterHeartbeatService.java | 4 ++--
.../hadoop/hdfs/server/federation/router/RouterRpcClient.java | 4 ++--
.../hadoop/hdfs/server/federation/router/RouterRpcServer.java | 6 +++---
.../hadoop/hdfs/server/federation/store/StateStoreService.java | 2 +-
.../federation/store/driver/impl/StateStoreFileBaseImpl.java | 2 +-
7 files changed, 11 insertions(+), 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hadoop/blob/c4d3636c/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationMetrics.java
----------------------------------------------------------------------
diff --git a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationMetrics.java b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationMetrics.java
index a99a26a..970bd4f 100644
--- a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationMetrics.java
+++ b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/FederationMetrics.java
@@ -456,7 +456,7 @@ public class FederationMetrics implements FederationMBean {
dev = (float) Math.sqrt(dev / usages.length);
}
} catch (IOException e) {
- LOG.info("Cannot get the live nodes: {}", e.getMessage());
+ LOG.error("Cannot get the live nodes: {}", e.getMessage());
}
final Map<String, Object> innerInfo = new HashMap<>();
http://git-wip-us.apache.org/repos/asf/hadoop/blob/c4d3636c/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/order/LocalResolver.java
----------------------------------------------------------------------
diff --git a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/order/LocalResolver.java b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/order/LocalResolver.java
index b6bd4b3..afc49c7 100644
--- a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/order/LocalResolver.java
+++ b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/order/LocalResolver.java
@@ -210,8 +210,7 @@ public class LocalResolver extends RouterResolver<String, String> {
}
}
} catch (IOException ioe) {
- LOG.error("Cannot get Namenodes from the State Store: {}",
- ioe.getMessage());
+ LOG.error("Cannot get Namenodes from the State Store", ioe);
}
return ret;
}
http://git-wip-us.apache.org/repos/asf/hadoop/blob/c4d3636c/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterHeartbeatService.java
----------------------------------------------------------------------
diff --git a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterHeartbeatService.java b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterHeartbeatService.java
index fe172c2..a7f02d3 100644
--- a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterHeartbeatService.java
+++ b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterHeartbeatService.java
@@ -100,7 +100,7 @@ public class RouterHeartbeatService extends PeriodicService {
LOG.debug("Router heartbeat for router {}", routerId);
}
} catch (IOException e) {
- LOG.error("Cannot heartbeat router {}: {}", routerId, e.getMessage());
+ LOG.error("Cannot heartbeat router {}", routerId, e);
}
} else {
LOG.warn("Cannot heartbeat router {}: State Store unavailable", routerId);
@@ -132,7 +132,7 @@ public class RouterHeartbeatService extends PeriodicService {
}
}
} catch (Exception e) {
- LOG.error("Cannot get version for {}: {}", clazz, e.getMessage());
+ LOG.error("Cannot get version for {}", clazz, e);
}
return version;
}
http://git-wip-us.apache.org/repos/asf/hadoop/blob/c4d3636c/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java
----------------------------------------------------------------------
diff --git a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java
index 6c657b2..513e867 100644
--- a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java
+++ b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java
@@ -1067,8 +1067,8 @@ public class RouterRpcClient {
results.put(location, clazz.cast(result));
} catch (CancellationException ce) {
T loc = orderedLocations.get(i);
- String msg =
- "Invocation to \"" + loc + "\" for \"" + method + "\" timed out";
+ String msg = "Invocation to \"" + loc + "\" for \""
+ + method.getMethodName() + "\" timed out";
LOG.error(msg);
IOException ioe = new SubClusterTimeoutException(msg);
exceptions.put(location, ioe);
http://git-wip-us.apache.org/repos/asf/hadoop/blob/c4d3636c/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java
----------------------------------------------------------------------
diff --git a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java
index 0dc2a69..f4c010c 100644
--- a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java
+++ b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java
@@ -2293,7 +2293,7 @@ public class RouterRpcServer extends AbstractService
return entry.isAll();
}
} catch (IOException e) {
- LOG.error("Cannot get mount point: {}", e.getMessage());
+ LOG.error("Cannot get mount point", e);
}
}
return false;
@@ -2314,7 +2314,7 @@ public class RouterRpcServer extends AbstractService
return true;
}
} catch (IOException e) {
- LOG.error("Cannot get mount point: {}", e.getMessage());
+ LOG.error("Cannot get mount point", e);
}
}
return false;
@@ -2343,7 +2343,7 @@ public class RouterRpcServer extends AbstractService
ret.put(child, entry.getDateModified());
}
} catch (IOException e) {
- LOG.error("Cannot get mount point: {}", e.getMessage());
+ LOG.error("Cannot get mount point", e);
}
}
return ret;
http://git-wip-us.apache.org/repos/asf/hadoop/blob/c4d3636c/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/StateStoreService.java
----------------------------------------------------------------------
diff --git a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/StateStoreService.java b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/StateStoreService.java
index ccbde09..a0744a6 100644
--- a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/StateStoreService.java
+++ b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/StateStoreService.java
@@ -183,7 +183,7 @@ public class StateStoreService extends CompositeService {
} catch (NotCompliantMBeanException e) {
throw new RuntimeException("Bad StateStoreMBean setup", e);
} catch (MetricsException e) {
- LOG.info("Failed to register State Store bean {}", e.getMessage());
+ LOG.error("Failed to register State Store bean {}", e.getMessage());
}
super.serviceInit(this.conf);
http://git-wip-us.apache.org/repos/asf/hadoop/blob/c4d3636c/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java
----------------------------------------------------------------------
diff --git a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java
index 6638d1c..15fc9c1 100644
--- a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java
+++ b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java
@@ -361,7 +361,7 @@ public abstract class StateStoreFileBaseImpl
try {
writer.close();
} catch (IOException e) {
- LOG.error("Cannot close the writer for {}", recordPathTemp);
+ LOG.error("Cannot close the writer for {}", recordPathTemp, e);
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org