You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/07/27 07:48:36 UTC
[GitHub] codecov-io edited a comment on issue #2146: [Dubbo-2017]Fix redis
auth problem for RedisProtocol(merge to 2.6.x PR)
codecov-io edited a comment on issue #2146: [Dubbo-2017]Fix redis auth problem for RedisProtocol(merge to 2.6.x PR)
URL: https://github.com/apache/incubator-dubbo/pull/2146#issuecomment-408340532
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2146?src=pr&el=h1) Report
> Merging [#2146](https://codecov.io/gh/apache/incubator-dubbo/pull/2146?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/0882c83bb9c772966d57cbf161a60ec3633f1e1e?src=pr&el=desc) will **decrease** coverage by `0.1%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2146?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 2.6.x #2146 +/- ##
============================================
- Coverage 47.36% 47.26% -0.11%
+ Complexity 4268 4261 -7
============================================
Files 557 557
Lines 24389 24386 -3
Branches 4336 4339 +3
============================================
- Hits 11553 11527 -26
- Misses 11041 11057 +16
- Partials 1795 1802 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2146?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...libaba/dubbo/rpc/protocol/redis/RedisProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2146/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1yZWRpcy9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9yZWRpcy9SZWRpc1Byb3RvY29sLmphdmE=) | `60.97% <100%> (+0.97%)` | `7 <0> (+1)` | :arrow_up: |
| [...om/alibaba/dubbo/registry/redis/RedisRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2146/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktcmVkaXMvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZWdpc3RyeS9yZWRpcy9SZWRpc1JlZ2lzdHJ5LmphdmE=) | `32.76% <66.66%> (-0.11%)` | `16 <0> (ø)` | |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2146/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2V4dGVuc2lvbi9TcHJpbmdFeHRlbnNpb25GYWN0b3J5LmphdmE=) | `73.07% <0%> (-11.54%)` | `8% <0%> (ø)` | |
| [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2146/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `57.5% <0%> (-8.75%)` | `19% <0%> (-2%)` | |
| [...ba/dubbo/remoting/transport/netty/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2146/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDbGllbnQuamF2YQ==) | `74.13% <0%> (-8.63%)` | `12% <0%> (-1%)` | |
| [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2146/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eUNoYW5uZWwuamF2YQ==) | `60% <0%> (-6.25%)` | `21% <0%> (-2%)` | |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2146/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `51.89% <0%> (-3.8%)` | `11% <0%> (-2%)` | |
| [...a/dubbo/remoting/transport/netty4/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2146/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eVNlcnZlci5qYXZh) | `72.13% <0%> (-3.28%)` | `9% <0%> (-1%)` | |
| [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2146/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `53.12% <0%> (-1.57%)` | `3% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2146?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2146?src=pr&el=footer). Last update [0882c83...6c15ba5](https://codecov.io/gh/apache/incubator-dubbo/pull/2146?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org