You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Dave Lewis (JIRA)" <ji...@apache.org> on 2007/10/17 03:29:50 UTC
[jira] Created: (SOLR-382) SpellCheckerRequestHandler does not
apply the onlyMorePopular flag.
SpellCheckerRequestHandler does not apply the onlyMorePopular flag.
-------------------------------------------------------------------
Key: SOLR-382
URL: https://issues.apache.org/jira/browse/SOLR-382
Project: Solr
Issue Type: Bug
Components: search
Reporter: Dave Lewis
Priority: Minor
The onlyMorePopular member does not have its value changed to meet the parameter when it is passed in. On top of that, even when it is passed in, the suggestSimilar method on SpellChecker will ignore it anyway because the ir and field parameters are passed in as null.
This patch sets onlyMorePopular according to the request, and passes in a non-null IndexReader and the search field we've already initialized.
Because the IndexReader currently being used is named nullReader, I may be missing a reason it is disabled on purpose.
This patch is working well for us so far.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-382) SpellCheckerRequestHandler does not
apply the onlyMorePopular flag.
Posted by "Dave Lewis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Lewis updated SOLR-382:
----------------------------
Attachment: SpellCheckRequestHandler.patch
The patch to set the value of onlyMorePopular from the request and to pass non-null IndexReader and search field to SpellChecker.suggestSimilar().
> SpellCheckerRequestHandler does not apply the onlyMorePopular flag.
> -------------------------------------------------------------------
>
> Key: SOLR-382
> URL: https://issues.apache.org/jira/browse/SOLR-382
> Project: Solr
> Issue Type: Bug
> Components: search
> Reporter: Dave Lewis
> Priority: Minor
> Attachments: SpellCheckRequestHandler.patch
>
>
> The onlyMorePopular member does not have its value changed to meet the parameter when it is passed in. On top of that, even when it is passed in, the suggestSimilar method on SpellChecker will ignore it anyway because the ir and field parameters are passed in as null.
> This patch sets onlyMorePopular according to the request, and passes in a non-null IndexReader and the search field we've already initialized.
> Because the IndexReader currently being used is named nullReader, I may be missing a reason it is disabled on purpose.
> This patch is working well for us so far.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-382) SpellCheckerRequestHandler does not
apply the onlyMorePopular flag.
Posted by "Dave Lewis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539856 ]
Dave Lewis commented on SOLR-382:
---------------------------------
That's great Mike, thanks! And thanks for sprucing up the patch as
well. :)
dave
> SpellCheckerRequestHandler does not apply the onlyMorePopular flag.
> -------------------------------------------------------------------
>
> Key: SOLR-382
> URL: https://issues.apache.org/jira/browse/SOLR-382
> Project: Solr
> Issue Type: Bug
> Components: spellchecker
> Reporter: Dave Lewis
> Assignee: Mike Klaas
> Priority: Minor
> Fix For: 1.3
>
> Attachments: SpellCheckRequestHandler.patch
>
>
> The onlyMorePopular member does not have its value changed to meet the parameter when it is passed in. On top of that, even when it is passed in, the suggestSimilar method on SpellChecker will ignore it anyway because the ir and field parameters are passed in as null.
> This patch sets onlyMorePopular according to the request, and passes in a non-null IndexReader and the search field we've already initialized.
> Because the IndexReader currently being used is named nullReader, I may be missing a reason it is disabled on purpose.
> This patch is working well for us so far.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-382) SpellCheckerRequestHandler does not
apply the onlyMorePopular flag.
Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535789 ]
Mike Klaas commented on SOLR-382:
---------------------------------
I've committed a modified patch that only passes in the IndexReader if the parameter is set (r585760). Thanks!
Note: might we want to rename the request parameters before 1.3 to use a common prefix, like spell.* or sp.*?
> SpellCheckerRequestHandler does not apply the onlyMorePopular flag.
> -------------------------------------------------------------------
>
> Key: SOLR-382
> URL: https://issues.apache.org/jira/browse/SOLR-382
> Project: Solr
> Issue Type: Bug
> Components: search
> Reporter: Dave Lewis
> Priority: Minor
> Attachments: SpellCheckRequestHandler.patch
>
>
> The onlyMorePopular member does not have its value changed to meet the parameter when it is passed in. On top of that, even when it is passed in, the suggestSimilar method on SpellChecker will ignore it anyway because the ir and field parameters are passed in as null.
> This patch sets onlyMorePopular according to the request, and passes in a non-null IndexReader and the search field we've already initialized.
> Because the IndexReader currently being used is named nullReader, I may be missing a reason it is disabled on purpose.
> This patch is working well for us so far.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-382) SpellCheckerRequestHandler does not
apply the onlyMorePopular flag.
Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Klaas updated SOLR-382:
----------------------------
Component/s: (was: search)
spellchecker
Assignee: Mike Klaas
> SpellCheckerRequestHandler does not apply the onlyMorePopular flag.
> -------------------------------------------------------------------
>
> Key: SOLR-382
> URL: https://issues.apache.org/jira/browse/SOLR-382
> Project: Solr
> Issue Type: Bug
> Components: spellchecker
> Reporter: Dave Lewis
> Assignee: Mike Klaas
> Priority: Minor
> Attachments: SpellCheckRequestHandler.patch
>
>
> The onlyMorePopular member does not have its value changed to meet the parameter when it is passed in. On top of that, even when it is passed in, the suggestSimilar method on SpellChecker will ignore it anyway because the ir and field parameters are passed in as null.
> This patch sets onlyMorePopular according to the request, and passes in a non-null IndexReader and the search field we've already initialized.
> Because the IndexReader currently being used is named nullReader, I may be missing a reason it is disabled on purpose.
> This patch is working well for us so far.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-382) SpellCheckerRequestHandler does not
apply the onlyMorePopular flag.
Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Klaas resolved SOLR-382.
-----------------------------
Resolution: Fixed
Fix Version/s: 1.3
> SpellCheckerRequestHandler does not apply the onlyMorePopular flag.
> -------------------------------------------------------------------
>
> Key: SOLR-382
> URL: https://issues.apache.org/jira/browse/SOLR-382
> Project: Solr
> Issue Type: Bug
> Components: spellchecker
> Reporter: Dave Lewis
> Assignee: Mike Klaas
> Priority: Minor
> Fix For: 1.3
>
> Attachments: SpellCheckRequestHandler.patch
>
>
> The onlyMorePopular member does not have its value changed to meet the parameter when it is passed in. On top of that, even when it is passed in, the suggestSimilar method on SpellChecker will ignore it anyway because the ir and field parameters are passed in as null.
> This patch sets onlyMorePopular according to the request, and passes in a non-null IndexReader and the search field we've already initialized.
> Because the IndexReader currently being used is named nullReader, I may be missing a reason it is disabled on purpose.
> This patch is working well for us so far.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.