You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Lenny Primak (Created) (JIRA)" <ji...@apache.org> on 2011/10/23 23:30:32 UTC
[jira] [Created] (TAP5-1717) Assets get cache expiry header of year
1979 in production mode
Assets get cache expiry header of year 1979 in production mode
--------------------------------------------------------------
Key: TAP5-1717
URL: https://issues.apache.org/jira/browse/TAP5-1717
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.3, 5.4
Reporter: Lenny Primak
Priority: Critical
Both ContextAssetRequestHandler and StackAssetRequestHandler do not set
lastModified date correctly in production mode. They are set to zero,
which when returned in the browser, the expire header is set to 1979,
which leads to no assets being cached whatsoever, leading to poor performance.
This is with yuicompressor enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1717) Assets get cache expiry header of year
1979 in production mode
Posted by "Howard M. Lewis Ship (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1717.
--------------------------------------
Resolution: Fixed
Fix Version/s: 5.3
> Assets get cache expiry header of year 1979 in production mode
> --------------------------------------------------------------
>
> Key: TAP5-1717
> URL: https://issues.apache.org/jira/browse/TAP5-1717
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3, 5.4
> Reporter: Lenny Primak
> Assignee: Howard M. Lewis Ship
> Priority: Critical
> Fix For: 5.3
>
>
> Both ContextAssetRequestHandler and StackAssetRequestHandler do not set
> lastModified date correctly in production mode. They are set to zero,
> which when returned in the browser, the expire header is set to 1979,
> which leads to no assets being cached whatsoever, leading to poor performance.
> This is with yuicompressor enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1717) Assets get cache expiry header of year
1979 in production mode
Posted by "Howard M. Lewis Ship (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1717.
--------------------------------------
Resolution: Fixed
Fix Version/s: 5.3
> Assets get cache expiry header of year 1979 in production mode
> --------------------------------------------------------------
>
> Key: TAP5-1717
> URL: https://issues.apache.org/jira/browse/TAP5-1717
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3, 5.4
> Reporter: Lenny Primak
> Assignee: Howard M. Lewis Ship
> Priority: Critical
> Fix For: 5.3
>
>
> Both ContextAssetRequestHandler and StackAssetRequestHandler do not set
> lastModified date correctly in production mode. They are set to zero,
> which when returned in the browser, the expire header is set to 1979,
> which leads to no assets being cached whatsoever, leading to poor performance.
> This is with yuicompressor enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1717) Assets get cache expiry header of
year 1979 in production mode
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134222#comment-13134222 ]
Hudson commented on TAP5-1717:
------------------------------
Integrated in tapestry-trunk-freestyle #602 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/602/])
TAP5-1717: Assets get cache expiry header of year 1979 in production mode
hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1188195
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/ResourceChangeTrackerImpl.java
> Assets get cache expiry header of year 1979 in production mode
> --------------------------------------------------------------
>
> Key: TAP5-1717
> URL: https://issues.apache.org/jira/browse/TAP5-1717
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3, 5.4
> Reporter: Lenny Primak
> Assignee: Howard M. Lewis Ship
> Priority: Critical
> Fix For: 5.3
>
>
> Both ContextAssetRequestHandler and StackAssetRequestHandler do not set
> lastModified date correctly in production mode. They are set to zero,
> which when returned in the browser, the expire header is set to 1979,
> which leads to no assets being cached whatsoever, leading to poor performance.
> This is with yuicompressor enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1717) Assets get cache expiry header of
year 1979 in production mode
Posted by "Lenny Primak (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133763#comment-13133763 ]
Lenny Primak commented on TAP5-1717:
------------------------------------
I traced this down to ResourceChangeTrackerImpl,java line 54...
trackResource always returns timestamp of zero in production mode...
-----------
public long trackResource(Resource resource)
{
if (tracker == null)
{
return 0;
}
return tracker.add(resource.toURL());
}
> Assets get cache expiry header of year 1979 in production mode
> --------------------------------------------------------------
>
> Key: TAP5-1717
> URL: https://issues.apache.org/jira/browse/TAP5-1717
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3, 5.4
> Reporter: Lenny Primak
> Priority: Critical
>
> Both ContextAssetRequestHandler and StackAssetRequestHandler do not set
> lastModified date correctly in production mode. They are set to zero,
> which when returned in the browser, the expire header is set to 1979,
> which leads to no assets being cached whatsoever, leading to poor performance.
> This is with yuicompressor enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TAP5-1717) Assets get cache expiry header of
year 1979 in production mode
Posted by "Howard M. Lewis Ship (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-1717:
------------------------------------------
Assignee: Howard M. Lewis Ship
> Assets get cache expiry header of year 1979 in production mode
> --------------------------------------------------------------
>
> Key: TAP5-1717
> URL: https://issues.apache.org/jira/browse/TAP5-1717
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3, 5.4
> Reporter: Lenny Primak
> Assignee: Howard M. Lewis Ship
> Priority: Critical
>
> Both ContextAssetRequestHandler and StackAssetRequestHandler do not set
> lastModified date correctly in production mode. They are set to zero,
> which when returned in the browser, the expire header is set to 1979,
> which leads to no assets being cached whatsoever, leading to poor performance.
> This is with yuicompressor enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1717) Assets get cache expiry header of
year 1979 in production mode
Posted by "Lenny Primak (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133763#comment-13133763 ]
Lenny Primak commented on TAP5-1717:
------------------------------------
I traced this down to ResourceChangeTrackerImpl,java line 54...
trackResource always returns timestamp of zero in production mode...
-----------
public long trackResource(Resource resource)
{
if (tracker == null)
{
return 0;
}
return tracker.add(resource.toURL());
}
> Assets get cache expiry header of year 1979 in production mode
> --------------------------------------------------------------
>
> Key: TAP5-1717
> URL: https://issues.apache.org/jira/browse/TAP5-1717
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3, 5.4
> Reporter: Lenny Primak
> Priority: Critical
>
> Both ContextAssetRequestHandler and StackAssetRequestHandler do not set
> lastModified date correctly in production mode. They are set to zero,
> which when returned in the browser, the expire header is set to 1979,
> which leads to no assets being cached whatsoever, leading to poor performance.
> This is with yuicompressor enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TAP5-1717) Assets get cache expiry header of
year 1979 in production mode
Posted by "Howard M. Lewis Ship (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-1717:
------------------------------------------
Assignee: Howard M. Lewis Ship
> Assets get cache expiry header of year 1979 in production mode
> --------------------------------------------------------------
>
> Key: TAP5-1717
> URL: https://issues.apache.org/jira/browse/TAP5-1717
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3, 5.4
> Reporter: Lenny Primak
> Assignee: Howard M. Lewis Ship
> Priority: Critical
>
> Both ContextAssetRequestHandler and StackAssetRequestHandler do not set
> lastModified date correctly in production mode. They are set to zero,
> which when returned in the browser, the expire header is set to 1979,
> which leads to no assets being cached whatsoever, leading to poor performance.
> This is with yuicompressor enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1717) Assets get cache expiry header of
year 1979 in production mode
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134222#comment-13134222 ]
Hudson commented on TAP5-1717:
------------------------------
Integrated in tapestry-trunk-freestyle #602 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/602/])
TAP5-1717: Assets get cache expiry header of year 1979 in production mode
hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1188195
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/ResourceChangeTrackerImpl.java
> Assets get cache expiry header of year 1979 in production mode
> --------------------------------------------------------------
>
> Key: TAP5-1717
> URL: https://issues.apache.org/jira/browse/TAP5-1717
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3, 5.4
> Reporter: Lenny Primak
> Assignee: Howard M. Lewis Ship
> Priority: Critical
> Fix For: 5.3
>
>
> Both ContextAssetRequestHandler and StackAssetRequestHandler do not set
> lastModified date correctly in production mode. They are set to zero,
> which when returned in the browser, the expire header is set to 1979,
> which leads to no assets being cached whatsoever, leading to poor performance.
> This is with yuicompressor enabled.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira