You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/01/31 07:22:45 UTC
[GitHub] [camel-kamelets] indiealexh opened a new pull request #762: WIP: Oracle Database Sink & Source
indiealexh opened a new pull request #762:
URL: https://github.com/apache/camel-kamelets/pull/762
Add Oracle Database sink and source Kamelet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] indiealexh commented on pull request #762: WIP: Oracle Database Sink & Source
Posted by GitBox <gi...@apache.org>.
indiealexh commented on pull request #762:
URL: https://github.com/apache/camel-kamelets/pull/762#issuecomment-1025458369
> We cannot use the drive from ora le due to license. So I would remove the explicit dependency and add the instruction in the description.
Can you point to an example of where this has been done before? Perhaps I should just make a generic JDBC Kamelet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #762: WIP: Oracle Database Sink & Source
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #762:
URL: https://github.com/apache/camel-kamelets/pull/762#issuecomment-1025452939
We cannot use the drive from ora le due to license. So I would remove the explicit dependency and add the instruction in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #762: WIP: Oracle Database Sink & Source
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #762:
URL: https://github.com/apache/camel-kamelets/pull/762#issuecomment-1027612169
Did you have time to have a look at updating this? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] indiealexh edited a comment on pull request #762: WIP: Oracle Database Sink & Source
Posted by GitBox <gi...@apache.org>.
indiealexh edited a comment on pull request #762:
URL: https://github.com/apache/camel-kamelets/pull/762#issuecomment-1025458369
> We cannot use the drive from ora le due to license. So I would remove the explicit dependency and add the instruction in the description.
Can you point to an example of where this has been done before? Perhaps I should just make a generic JDBC Kamelet?
(Thanks oracle for making life harder)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #762: WIP: Oracle Database Sink & Source
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #762:
URL: https://github.com/apache/camel-kamelets/pull/762#issuecomment-1025504468
Btw the skeleton of the Kamelet is good, you just need to remove the dependency and add the instruction to the description. Thanks a lot for working on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #762: WIP: Oracle Database Sink & Source
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #762:
URL: https://github.com/apache/camel-kamelets/pull/762#issuecomment-1025503777
Hello,
You can do something like this: https://github.com/apache/camel-kamelets/blob/main/kamelets/sqlserver-source.kamelet.yaml#L35
Personally I think makes a generic jdbc kamelet it's a bit too generic. The aim of Kamelets is being able to grab one of them to integrate with a specific external service or db. So IMO, it would be really better to have one Kamelet for each Database kind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #762: WIP: Oracle Database Sink & Source
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #762:
URL: https://github.com/apache/camel-kamelets/pull/762#issuecomment-1046497775
If you don't mind, I'll clean up and merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] indiealexh commented on pull request #762: WIP: Oracle Database Sink & Source
Posted by GitBox <gi...@apache.org>.
indiealexh commented on pull request #762:
URL: https://github.com/apache/camel-kamelets/pull/762#issuecomment-1047484469
> If you don't mind, I'll clean up and merge this PR.
Yeah, sorry been crazy busy at work and havn't had a chance to follow up with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd closed pull request #762: WIP: Oracle Database Sink & Source
Posted by GitBox <gi...@apache.org>.
oscerd closed pull request #762:
URL: https://github.com/apache/camel-kamelets/pull/762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org