[GitHub] [incubator-doris] morningman commented on a change in pull request #3120: [Temp Partition] Support loading data into temp partitions

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #3120: [Temp Partition] Support loading data into temp partitions
URL: https://github.com/apache/incubator-doris/pull/3120#discussion_r393721894
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/planner/OlapTableSink.java
 ##########
 @@ -293,7 +293,11 @@ private TOlapTableLocationParam createLocation(OlapTable table) throws UserExcep
         TOlapTableLocationParam locationParam = new TOlapTableLocationParam();
         // BE id -> path hash
         Multimap<Long, Long> allBePathsMap = HashMultimap.create();
-        for (Partition partition : table.getPartitions()) {
+        for (Partition partition : table.getAllPartitions()) {
+            if (!partitionIds.isEmpty() && !partitionIds.contains(partition.getId())) {
 
 Review comment:
   I didn't get you point? no need to check what ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org