You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/05/17 11:53:19 UTC

[GitHub] ShootingSpace commented on a change in pull request #10461: allow user to define unknown token symbol

ShootingSpace commented on a change in pull request #10461: allow user to define unknown token symbol
URL: https://github.com/apache/incubator-mxnet/pull/10461#discussion_r188930597
 
 

 ##########
 File path: python/mxnet/rnn/io.py
 ##########
 @@ -58,6 +62,8 @@ def encode_sentences(sentences, vocab=None, invalid_label=-1, invalid_key='\n',
     if vocab is None:
         vocab = {invalid_key: invalid_label}
         new_vocab = True
+    elif unknown_token:
+        new_vocab = True
 
 Review comment:
   Sorry for late reply (in exam). Just fix according to your suggestion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services