You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/02/16 11:50:50 UTC
[GitHub] [incubator-kyuubi] martin-g opened a new pull request #1918: Build and test on Linux ARM64
martin-g opened a new pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918
### _Why are the changes needed?_
More and more software development is being done on ARM64 CPU architecture.
It would be good if Kyuubi is being regularly tested on Linux ARM64 (aarch64).
### _How was this patch tested?_
- [X] An additional job is added to the TravisCI config. Now the build will be executed on both AMD64 and ARM64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1044036692
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1918](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ee470b3) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/47b0fecd6add7d49fbcffacf820688695b27e89a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (47b0fec) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ee470b3 differs from pull request most recent head 01e3b94. Consider uploading reports for the commit 01e3b94 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1918 +/- ##
============================================
- Coverage 60.93% 60.90% -0.03%
Complexity 72 72
============================================
Files 303 303
Lines 14768 14768
Branches 1902 1902
============================================
- Hits 8999 8995 -4
Misses 5006 5006
- Partials 763 767 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/KyuubiSQLException.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9LeXV1YmlTUUxFeGNlcHRpb24uc2NhbGE=) | `92.77% <0.00%> (-1.21%)` | :arrow_down: |
| [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `84.31% <0.00%> (-0.99%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `87.25% <0.00%> (-0.99%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [47b0fec...01e3b94](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] Yikun edited a comment on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1041456292
@ulysses-you Thanks for ping me, I have a short conversations with @yaooqinn, the easiest way to add arm support for Kyuubi might just use travis. The apache also purchase travis license for apache projects usage.
@martin-g And I think we can only enable arm ci in travis, because Kyuubi are using github action to validate x86 test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] martin-g commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1044170867
It failed with the same error at https://app.travis-ci.com/github/apache/incubator-kyuubi/jobs/560243764
I will take a deeper look why it happens!
But it seems the main problem is that there are many errors like this one:
```
08:38:19.496 Flink-RestClusterClient-IO-thread-1 DEBUG RestClient: Sending request of class class org.apache.flink.runtime.rest.messages.job.coordination.ClientCoordinationRequestBody to localhost:8081/v1/jobs/9ce1cef948270e28356b82b46d7ac267/coordinators/3d05135cf7d8f1375d8f655ba9d20255
08:38:19.519 flink-akka.actor.default-dispatcher-9 ERROR ClientCoordinationHandler: Unhandled exception.
org.apache.flink.runtime.messages.FlinkJobNotFoundException: Could not find Flink job (9ce1cef948270e28356b82b46d7ac267)
at org.apache.flink.runtime.dispatcher.Dispatcher.getJobMasterGateway(Dispatcher.java:920) ~[flink-runtime-1.14.3.jar:1.14.3]
at org.apache.flink.runtime.dispatcher.Dispatcher.performOperationOnJobMasterGateway(Dispatcher.java:934) ~[flink-runtime-1.14.3.jar:1.14.3]
at org.apache.flink.runtime.dispatcher.Dispatcher.deliverCoordinationRequestToCoordinator(Dispatcher.java:718) ~[flink-runtime-1.14.3.jar:1.14.3]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_292]
...
```
Any hints what could be the problem here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 edited a comment on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1046239940
I did a try in this weekend on Android ARM64 machine.
The brief environment information
```
╲ ▁▂▂▂▁ ╱
▄███████▄
▄██ ███ ██▄
▄███████████▄ OS: Android 11
▄█ ▄▄▄▄▄▄▄▄▄▄▄▄▄ █▄ Device: Lenovo TB-J716F (J716F)
██ █████████████ ██ ROM: TB-J716F_CN_OPEN_USER_Q00209.3_R_ZUI_13.0.430_ST_220113
██ █████████████ ██ Baseband: apq
██ █████████████ ██ Kernel: aarch64 Linux 4.19.152-perf+
██ █████████████ ██ Uptime:
█████████████ CPU: Qualcomm Technologies, Inc KONA
███████████ GPU: Qualcomm Technologies, Inc KONA
██ ██ RAM: 3027MiB / 5667MiB
██ ██
```
And I can only get the JDK 17 provided by the OS package manager `apt`.
```
openjdk version "17-internal" 2021-09-14
OpenJDK Runtime Environment (build 17-internal+0-adhoc..src)
OpenJDK 64-Bit Server VM (build 17-internal+0-adhoc..src, mixed mode)
```
Encounter some issues related to JDK-17, partial fixed but still can not pass all UTs.
Test command:
```
build/mvn install -Dzookeeper.version=3.5.9 -Dmaven.plugin.scalatest.exclude.tags=org.apache.kyuubi.tags.ExtendedSQLTest,org.apache.kyuubi.tags.DeltaTest,org.apache.kyuubi.tags.IcebergTest,org.apache.kyuubi.tags.HudiTest
```
- https://github.com/apache/incubator-kyuubi/pull/1939
- https://github.com/apache/incubator-kyuubi/pull/1940
- https://github.com/apache/incubator-kyuubi/issues/1941
- https://github.com/apache/incubator-kyuubi/pull/1943
The current status,
`kyuubi-flink-sql-engine` failed because of Flink 1.14 depends on`asm-7` which does not support JDK 17.
```
Caused by: org.apache.flink.table.api.ValidationException: Unable to extract a type inference from method:
public java.lang.String LowerUDF.eval(java.lang.String)
at org.apache.flink.table.types.extraction.ExtractionUtils.extractionError(ExtractionUtils.java:362)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractResultMappings(FunctionMappingExtractor.java:183)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractOutputMapping(FunctionMappingExtractor.java:114)
... 29 more
Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 61
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:195)
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:176)
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:162)
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:283)
at org.apache.flink.table.types.extraction.ExtractionUtils.getClassReader(ExtractionUtils.java:747)
at org.apache.flink.table.types.extraction.ExtractionUtils.extractExecutableNames(ExtractionUtils.java:721)
at org.apache.flink.table.types.extraction.ExtractionUtils.extractMethodParameterNames(ExtractionUtils.java:656)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractArgumentNames(FunctionMappingExtractor.java:429)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.lambda$createParameterSignatureExtraction$9(FunctionMappingExtractor.java:367)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.putExtractedResultMappings(FunctionMappingExtractor.java:324)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.collectMethodMappings(FunctionMappingExtractor.java:269)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractResultMappings(FunctionMappingExtractor.java:169)
```
`kyuubi-spark-sql-engine` failed in Delta test with the following stacktrace, passed with `-Dmaven.plugin.scalatest.exclude.tags=org.apache.kyuubi.tags.ExtendedSQLTest,org.apache.kyuubi.tags.DeltaTest,org.apache.kyuubi.tags.IcebergTest,org.apache.kyuubi.tags.HudiTest`
```
Caused by: java.lang.IllegalArgumentException: newLimit > capacity: (84 > 78)
at java.base/java.nio.Buffer.createLimitException(Buffer.java:395)
at java.base/java.nio.Buffer.limit(Buffer.java:369)
at java.base/java.nio.ByteBuffer.limit(ByteBuffer.java:1529)
at java.base/java.nio.MappedByteBuffer.limit(MappedByteBuffer.java:330)
at java.base/java.nio.MappedByteBuffer.limit(MappedByteBuffer.java:73)
at org.xerial.snappy.Snappy.compress(Snappy.java:156)
at org.apache.parquet.hadoop.codec.SnappyCompressor.compress(SnappyCompressor.java:78)
at org.apache.hadoop.io.compress.CompressorStream.compress(CompressorStream.java:81)
at org.apache.hadoop.io.compress.CompressorStream.finish(CompressorStream.java:92)
at org.apache.parquet.hadoop.CodecFactory$HeapBytesCompressor.compress(CodecFactory.java:167)
at org.apache.parquet.hadoop.ColumnChunkPageWriteStore$ColumnChunkPageWriter.writePage(ColumnChunkPageWriteStore.java:168)
at org.apache.parquet.column.impl.ColumnWriterV1.writePage(ColumnWriterV1.java:59)
at org.apache.parquet.column.impl.ColumnWriterBase.writePage(ColumnWriterBase.java:387)
at org.apache.parquet.column.impl.ColumnWriteStoreBase.flush(ColumnWriteStoreBase.java:186)
at org.apache.parquet.column.impl.ColumnWriteStoreV1.flush(ColumnWriteStoreV1.java:29)
at org.apache.parquet.hadoop.InternalParquetRecordWriter.flushRowGroupToStore(InternalParquetRecordWriter.java:185)
at org.apache.parquet.hadoop.InternalParquetRecordWriter.close(InternalParquetRecordWriter.java:124)
at org.apache.parquet.hadoop.ParquetRecordWriter.close(ParquetRecordWriter.java:164)
at org.apache.spark.sql.execution.datasources.parquet.ParquetOutputWriter.close(ParquetOutputWriter.scala:41)
at org.apache.spark.sql.execution.datasources.FileFormatDataWriter.releaseCurrentWriter(FileFormatDataWriter.scala:64)
at org.apache.spark.sql.execution.datasources.FileFormatDataWriter.releaseResources(FileFormatDataWriter.scala:75)
at org.apache.spark.sql.execution.datasources.FileFormatDataWriter.commit(FileFormatDataWriter.scala:105)
at org.apache.spark.sql.execution.datasources.FileFormatWriter$.$anonfun$executeTask$1(FileFormatWriter.scala:305)
at org.apache.spark.util.Utils$.tryWithSafeFinallyAndFailureCallbacks(Utils.scala:1496)
at org.apache.spark.sql.execution.datasources.FileFormatWriter$.executeTask(FileFormatWriter.scala:311)
```
Now, I'm blocking on the lack of compute engine JDK 17 support.
Flink has no exactly version which officially support JDK 17 https://issues.apache.org/jira/browse/FLINK-15736
Spark officially support JDK 17 since 3.3.0 https://issues.apache.org/jira/browse/SPARK-33772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] martin-g commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1046534165
It fails with
```
INFO] --- scala-maven-plugin:4.3.0:compile (scala-compile-first) @ kyuubi-ha_2.12 ---
[INFO] Using incremental compilation using Mixed compile order
[INFO] Compiler bridge file: /home/ubuntu/.sbt/1.0/zinc/org.scala-sbt/org.scala-sbt-compiler-bridge_2.12-1.3.1-bin_2.12.15__52.0-1.3.1_20191012T045515.jar
[INFO] compiler plugin: BasicArtifact(com.github.ghik,silencer-plugin_2.12.15,1.7.6,null)
[INFO] Compiling 2 Scala sources to /home/ubuntu/git/apache/incubator-kyuubi/kyuubi-ha/target/scala-2.12/classes ...
[ERROR] [Error] /home/ubuntu/git/apache/incubator-kyuubi/kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/ZooKeeperACLProvider.scala:22: object data is not a member of package org.apache.zookeeper
[ERROR] [Error] /home/ubuntu/git/apache/incubator-kyuubi/kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/ZooKeeperACLProvider.scala:34: not found: type ACL
[ERROR] [Error] /home/ubuntu/git/apache/incubator-kyuubi/kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/ZooKeeperACLProvider.scala:35: not found: type ACL
[ERROR] [Error] /home/ubuntu/git/apache/incubator-kyuubi/kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/ZooKeeperACLProvider.scala:68: not found: type ACL
[ERROR] [Error] /home/ubuntu/git/apache/incubator-kyuubi/kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/zookeeper/ServiceDiscoveryClient.scala:102: Class org.apache.zookeeper.data.Stat not found - continuing with a stub.
[ERROR] 5 errors found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] martin-g commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1044001225
Yes, I've reduced it a bit by suppressing Maven's network transfer progress but it wasn't enough. I will try by changing Maven's log level to WARN.
But also there is an actual error:
```
KyuubiHiveDriverSuite:
*** RUN ABORTED ***
java.lang.IncompatibleClassChangeError: class org.apache.spark.sql.catalyst.plans.logical.DynamicFileFilterWithCardinalityCheck has interface org.apache.spark.sql.catalyst.plans.logical.BinaryNode as super class
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:756)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
```
It happened in both runs:
https://app.travis-ci.com/github/apache/incubator-kyuubi/jobs/559953401
https://app.travis-ci.com/github/apache/incubator-kyuubi/jobs/559934048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1044036692
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1918](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (01e3b94) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/47b0fecd6add7d49fbcffacf820688695b27e89a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (47b0fec) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1918 +/- ##
============================================
+ Coverage 60.93% 60.96% +0.02%
Complexity 72 72
============================================
Files 303 304 +1
Lines 14768 14798 +30
Branches 1902 1909 +7
============================================
+ Hits 8999 9021 +22
- Misses 5006 5009 +3
- Partials 763 768 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.06% <0.00%> (-4.82%)` | :arrow_down: |
| [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `84.31% <0.00%> (-0.99%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `87.25% <0.00%> (-0.99%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.27% <0.00%> (-0.15%)` | :arrow_down: |
| [...g/apache/kyuubi/engine/flink/result/Constants.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL3Jlc3VsdC9Db25zdGFudHMuamF2YQ==) | `50.00% <0.00%> (ø)` | |
| [...che/kyuubi/engine/trino/operation/GetColumns.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9HZXRDb2x1bW5zLnNjYWxh) | `88.88% <0.00%> (ø)` | |
| [...kyuubi/engine/trino/operation/TrinoOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9Ucmlub09wZXJhdGlvbi5zY2FsYQ==) | `50.94% <0.00%> (+1.92%)` | :arrow_up: |
| [...engine/trino/operation/TrinoOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9Ucmlub09wZXJhdGlvbk1hbmFnZXIuc2NhbGE=) | `95.00% <0.00%> (+10.78%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [47b0fec...01e3b94](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1044187917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] martin-g commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1046531334
Another problem that I'm facing locally with the tests is in kyuubi-ha_2.12 module:
```
[INFO] --- scalatest-maven-plugin:2.0.2:test (test) @ kyuubi-ha_2.12 ---
Discovery starting.
2022-02-21 06:44:15,036 ScalaTest-main ERROR Filters contains invalid attributes "onMatch", "onMismatch"
2022-02-21 06:44:15,057 ScalaTest-main ERROR Filters contains invalid attributes "onMatch", "onMismatch"
Discovery completed in 1 second, 705 milliseconds.
Run starting. Expected test count is: 8
HighAvailabilityConfSuite:
- kyuubi.ha.zookeeper.node.creation.timeout
ServiceDiscoverySuite:
- publish instance to embedded zookeeper server *** FAILED ***
org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /abc
at org.apache.zookeeper.KeeperException.create(KeeperException.java:102)
at org.apache.zookeeper.KeeperException.create(KeeperException.java:54)
at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1111)
at org.apache.curator.framework.imps.ExistsBuilderImpl$3.call(ExistsBuilderImpl.java:237)
at org.apache.curator.framework.imps.ExistsBuilderImpl$3.call(ExistsBuilderImpl.java:226)
at org.apache.curator.RetryLoop.callWithRetry(RetryLoop.java:109)
at org.apache.curator.framework.imps.ExistsBuilderImpl.pathInForegroundStandard(ExistsBuilderImpl.java:223)
at org.apache.curator.framework.imps.ExistsBuilderImpl.pathInForeground(ExistsBuilderImpl.java:216)
at org.apache.curator.framework.imps.ExistsBuilderImpl.forPath(ExistsBuilderImpl.java:175)
at org.apache.curator.framework.imps.ExistsBuilderImpl.forPath(ExistsBuilderImpl.java:32)
```
It seems Zookeeper will need to be upgraded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] martin-g commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1046544755
This helped for the compilation but the tests still fail:
```
- publish instance to embedded zookeeper server *** FAILED ***
org.apache.kyuubi.KyuubiException: Failed to Start NoopTBinaryFrontendServer
at org.apache.kyuubi.service.CompositeService.$anonfun$start$1(CompositeService.scala:52)
at org.apache.kyuubi.service.CompositeService.$anonfun$start$1$adapted(CompositeService.scala:45)
at scala.collection.mutable.ResizableArray.foreach(ResizableArray.scala:62)
at scala.collection.mutable.ResizableArray.foreach$(ResizableArray.scala:55)
at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:49)
at org.apache.kyuubi.service.CompositeService.start(CompositeService.scala:45)
at org.apache.kyuubi.service.Serverable.start(Serverable.scala:51)
at org.apache.kyuubi.service.AbstractNoopServer.start(AbstractNoopServer.scala:29)
at org.apache.kyuubi.ha.client.ServiceDiscoverySuite.$anonfun$new$1(ServiceDiscoverySuite.scala:81)
at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#discussion_r810836800
##########
File path: .travis.yml
##########
@@ -37,7 +47,9 @@ install:
- ./build/mvn --version
script:
- - ./build/mvn clean install -Dmaven.javadoc.skip=true -V
+ - export MVN_ARGS="-Dmaven.javadoc.skip=true -V -B -ntp -Dorg.slf4j.simpleLogger.defaultLogLevel=warn"
+ - ./build/mvn clean install -DskipTests $MVN_ARGS
+# - ./build/mvn test $MVN_ARGS
Review comment:
Since we have some issues with zookeeper, we can change it to `build/mvn test -pl kyuubi-common -am $MVN_ARGS` and merge this PR, then fix other issues and enable those module's test later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] Yikun commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1041456292
@ulysses-you Thanks for ping me, i have a short conversations with @yaooqinn, the easiest way to add arm support for Kyuubi might just use travis. The apache also purchase travis license for apache projects usage.
@martin-g And I think we can only enable arm in travis, because Kyuubi are using github action to validate x86 test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1043754488
It seems the failure is not related with this PR, the debug log is too large..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1046532026
@martin-g Does it helps? `build/mvn install -Dzookeeper.version=3.5.9`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#discussion_r810862887
##########
File path: .travis.yml
##########
@@ -37,7 +47,9 @@ install:
- ./build/mvn --version
script:
- - ./build/mvn clean install -Dmaven.javadoc.skip=true -V
+ - export MVN_ARGS="-Dmaven.javadoc.skip=true -V -B -ntp -Dorg.slf4j.simpleLogger.defaultLogLevel=warn"
+ - ./build/mvn clean install -DskipTests $MVN_ARGS
+ - ./build/mvn test $MVN_ARGS -pl kyuubi-common -am
Review comment:
A space is needed here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] martin-g commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1041426882
@yaooqinn I still don't see the check for TravisCI above and at https://app.travis-ci.com/github/apache/incubator-kyuubi/pull_requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1046536297
> It fails with
>
> ```
> INFO] --- scala-maven-plugin:4.3.0:compile (scala-compile-first) @ kyuubi-ha_2.12 ---
> [INFO] Using incremental compilation using Mixed compile order
> [INFO] Compiler bridge file: /home/ubuntu/.sbt/1.0/zinc/org.scala-sbt/org.scala-sbt-compiler-bridge_2.12-1.3.1-bin_2.12.15__52.0-1.3.1_20191012T045515.jar
> [INFO] compiler plugin: BasicArtifact(com.github.ghik,silencer-plugin_2.12.15,1.7.6,null)
> [INFO] Compiling 2 Scala sources to /home/ubuntu/git/apache/incubator-kyuubi/kyuubi-ha/target/scala-2.12/classes ...
> [ERROR] [Error] /home/ubuntu/git/apache/incubator-kyuubi/kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/ZooKeeperACLProvider.scala:22: object data is not a member of package org.apache.zookeeper
> [ERROR] [Error] /home/ubuntu/git/apache/incubator-kyuubi/kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/ZooKeeperACLProvider.scala:34: not found: type ACL
> [ERROR] [Error] /home/ubuntu/git/apache/incubator-kyuubi/kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/ZooKeeperACLProvider.scala:35: not found: type ACL
> [ERROR] [Error] /home/ubuntu/git/apache/incubator-kyuubi/kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/ZooKeeperACLProvider.scala:68: not found: type ACL
> [ERROR] [Error] /home/ubuntu/git/apache/incubator-kyuubi/kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/zookeeper/ServiceDiscoveryClient.scala:102: Class org.apache.zookeeper.data.Stat not found - continuing with a stub.
> [ERROR] 5 errors found
> ```
Oops, sorry, I forget that Zookeeper Client 3.5 requires a new dependeny, it should be aside with `org.apache.zookeeper:zookeeper`
```
<dependency>
<groupId>org.apache.zookeeper</groupId>
<artifactId>zookeeper-jute</artifactId>
<version>3.5.9</version>
</dependency>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1044036692
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1918](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4700c3e) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/47b0fecd6add7d49fbcffacf820688695b27e89a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (47b0fec) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1918 +/- ##
============================================
- Coverage 60.93% 60.89% -0.04%
+ Complexity 72 69 -3
============================================
Files 303 302 -1
Lines 14768 14785 +17
Branches 1902 1914 +12
============================================
+ Hits 8999 9004 +5
- Misses 5006 5012 +6
- Partials 763 769 +6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ubi/engine/spark/operation/PlanOnlyStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vUGxhbk9ubHlTdGF0ZW1lbnQuc2NhbGE=) | `62.85% <0.00%> (-13.01%)` | :arrow_down: |
| [...ubi/engine/flink/operation/PlanOnlyStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9mbGluay9vcGVyYXRpb24vUGxhbk9ubHlTdGF0ZW1lbnQuc2NhbGE=) | `78.57% <0.00%> (-5.43%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.06% <0.00%> (-4.82%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `84.40% <0.00%> (-3.84%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/KyuubiSQLException.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9LeXV1YmlTUUxFeGNlcHRpb24uc2NhbGE=) | `92.77% <0.00%> (-1.21%)` | :arrow_down: |
| [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `84.31% <0.00%> (-0.99%)` | :arrow_down: |
| [...la/org/apache/kyuubi/session/AbstractSession.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0Fic3RyYWN0U2Vzc2lvbi5zY2FsYQ==) | `98.87% <0.00%> (ø)` | |
| [...g/apache/kyuubi/engine/flink/result/Constants.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL3Jlc3VsdC9Db25zdGFudHMuamF2YQ==) | `50.00% <0.00%> (ø)` | |
| [...yuubi/sql/zorder/OptimizeZorderStatementBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvT3B0aW1pemVab3JkZXJTdGF0ZW1lbnRCYXNlLnNjYWxh) | `71.42% <0.00%> (ø)` | |
| [...sqlclassification/KyuubiGetSqlClassification.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstMy0xL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9zcWxjbGFzc2lmaWNhdGlvbi9LeXV1YmlHZXRTcWxDbGFzc2lmaWNhdGlvbi5zY2FsYQ==) | | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [47b0fec...4700c3e](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1041411567
@martin-g Can this work for Github actions？The Travis is disabled for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] martin-g commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1041446382
It is enabled now - https://app.travis-ci.com/github/apache/incubator-kyuubi/builds/246556417!
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] martin-g commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1041429064
About Github Actions:
GitHub Actions does not provide Linux/Mac ARM64 build nodes yet.
The only way is by using self-hosted runner nodes. I could provide you with such!
But there are security [implications](https://cwiki.apache.org/confluence/display/BUILDS/GitHub+Actions+status#GitHubActionsstatus-Security) with them. The good news is that the security concerns are valid only if you run contributors' Pull Requests on them. But you can still use the self-hosted runner for time scheduled workflows on `master` branch, i.e. to run only approved code there. The feedback for regressions will be a bit late, because the PR that broke something is already merged, but one can mitigate this by running the scheduled workflow several times per day.
Another option is to use custom Github Actions action runner. This is what Apache Airflow project does but it is more complicated setup. It allows workflow executions only for project members and predefined contributors. See https://github.com/apache/airflow/blob/main/.github/workflows/ci.yml#L75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1041447993
Thanks for the suggestions and generous offer @martin-g.
Let's first see whether Travis works or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#discussion_r810863066
##########
File path: .travis.yml
##########
@@ -29,6 +29,16 @@ scala:
jdk:
- openjdk8
+matrix:
+ include:
+ - name: Linux x86_64
+ arch: amd64
Review comment:
Remvoe amd64 test LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1046408042
Thanks @Yikun, will ask you for help when I get another time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yanghua commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1044295541
> cc @yanghua @SteNicholas @pan3793 can you take a look?
Let me try to find more details and figure out the solution on the weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1046534584
> It seems Zookeeper will need to be upgraded.
We have some plan here https://github.com/apache/incubator-kyuubi/issues/1941
We want Kyuubi to keep compatible with Zookeeper Server 3.4, because lots of Kyuubi users use CDH5/6 which bundles Zookeeper 3.4, we should be careful when upgrade Zookeeper Client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 edited a comment on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1046239940
I did a try in this weekend on Android ARM64 machine.
The brief environment information
```
╲ ▁▂▂▂▁ ╱
▄███████▄
▄██ ███ ██▄
▄███████████▄ OS: Android 11
▄█ ▄▄▄▄▄▄▄▄▄▄▄▄▄ █▄ Device: Lenovo TB-J716F (J716F)
██ █████████████ ██ ROM: TB-J716F_CN_OPEN_USER_Q00209.3_R_ZUI_13.0.430_ST_220113
██ █████████████ ██ Baseband: apq
██ █████████████ ██ Kernel: aarch64 Linux 4.19.152-perf+
██ █████████████ ██ Uptime:
█████████████ CPU: Qualcomm Technologies, Inc KONA
███████████ GPU: Qualcomm Technologies, Inc KONA
██ ██ RAM: 3027MiB / 5667MiB
██ ██
```
And I can only get the JDK-17 provided by the OS package manager `apt`.
```
openjdk version "17-internal" 2021-09-14
OpenJDK Runtime Environment (build 17-internal+0-adhoc..src)
OpenJDK 64-Bit Server VM (build 17-internal+0-adhoc..src, mixed mode)
```
Encounter some issues related to JDK-17, partial fixed but still can not pass all UTs.
Test command:
```
build/mvn install -Dzookeeper.version=3.5.9 -Dmaven.plugin.scalatest.exclude.tags=org.apache.kyuubi.tags.ExtendedSQLTest,org.apache.kyuubi.tags.DeltaTest,org.apache.kyuubi.tags.IcebergTest,org.apache.kyuubi.tags.HudiTest
```
- https://github.com/apache/incubator-kyuubi/pull/1939
- https://github.com/apache/incubator-kyuubi/pull/1940
- https://github.com/apache/incubator-kyuubi/issues/1941
- https://github.com/apache/incubator-kyuubi/pull/1943
The current status,
`kyuubi-flink-sql-engine` failed because of Flink 1.14 depends on`asm-7` which does not support JDK 17.
```
Caused by: org.apache.flink.table.api.ValidationException: Unable to extract a type inference from method:
public java.lang.String LowerUDF.eval(java.lang.String)
at org.apache.flink.table.types.extraction.ExtractionUtils.extractionError(ExtractionUtils.java:362)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractResultMappings(FunctionMappingExtractor.java:183)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractOutputMapping(FunctionMappingExtractor.java:114)
... 29 more
Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 61
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:195)
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:176)
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:162)
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:283)
at org.apache.flink.table.types.extraction.ExtractionUtils.getClassReader(ExtractionUtils.java:747)
at org.apache.flink.table.types.extraction.ExtractionUtils.extractExecutableNames(ExtractionUtils.java:721)
at org.apache.flink.table.types.extraction.ExtractionUtils.extractMethodParameterNames(ExtractionUtils.java:656)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractArgumentNames(FunctionMappingExtractor.java:429)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.lambda$createParameterSignatureExtraction$9(FunctionMappingExtractor.java:367)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.putExtractedResultMappings(FunctionMappingExtractor.java:324)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.collectMethodMappings(FunctionMappingExtractor.java:269)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractResultMappings(FunctionMappingExtractor.java:169)
```
`kyuubi-spark-sql-engine` failed in Delta test with the following stacktrace, passed with `-Dmaven.plugin.scalatest.exclude.tags=org.apache.kyuubi.tags.ExtendedSQLTest,org.apache.kyuubi.tags.DeltaTest,org.apache.kyuubi.tags.IcebergTest,org.apache.kyuubi.tags.HudiTest`
```
Caused by: java.lang.IllegalArgumentException: newLimit > capacity: (84 > 78)
at java.base/java.nio.Buffer.createLimitException(Buffer.java:395)
at java.base/java.nio.Buffer.limit(Buffer.java:369)
at java.base/java.nio.ByteBuffer.limit(ByteBuffer.java:1529)
at java.base/java.nio.MappedByteBuffer.limit(MappedByteBuffer.java:330)
at java.base/java.nio.MappedByteBuffer.limit(MappedByteBuffer.java:73)
at org.xerial.snappy.Snappy.compress(Snappy.java:156)
at org.apache.parquet.hadoop.codec.SnappyCompressor.compress(SnappyCompressor.java:78)
at org.apache.hadoop.io.compress.CompressorStream.compress(CompressorStream.java:81)
at org.apache.hadoop.io.compress.CompressorStream.finish(CompressorStream.java:92)
at org.apache.parquet.hadoop.CodecFactory$HeapBytesCompressor.compress(CodecFactory.java:167)
at org.apache.parquet.hadoop.ColumnChunkPageWriteStore$ColumnChunkPageWriter.writePage(ColumnChunkPageWriteStore.java:168)
at org.apache.parquet.column.impl.ColumnWriterV1.writePage(ColumnWriterV1.java:59)
at org.apache.parquet.column.impl.ColumnWriterBase.writePage(ColumnWriterBase.java:387)
at org.apache.parquet.column.impl.ColumnWriteStoreBase.flush(ColumnWriteStoreBase.java:186)
at org.apache.parquet.column.impl.ColumnWriteStoreV1.flush(ColumnWriteStoreV1.java:29)
at org.apache.parquet.hadoop.InternalParquetRecordWriter.flushRowGroupToStore(InternalParquetRecordWriter.java:185)
at org.apache.parquet.hadoop.InternalParquetRecordWriter.close(InternalParquetRecordWriter.java:124)
at org.apache.parquet.hadoop.ParquetRecordWriter.close(ParquetRecordWriter.java:164)
at org.apache.spark.sql.execution.datasources.parquet.ParquetOutputWriter.close(ParquetOutputWriter.scala:41)
at org.apache.spark.sql.execution.datasources.FileFormatDataWriter.releaseCurrentWriter(FileFormatDataWriter.scala:64)
at org.apache.spark.sql.execution.datasources.FileFormatDataWriter.releaseResources(FileFormatDataWriter.scala:75)
at org.apache.spark.sql.execution.datasources.FileFormatDataWriter.commit(FileFormatDataWriter.scala:105)
at org.apache.spark.sql.execution.datasources.FileFormatWriter$.$anonfun$executeTask$1(FileFormatWriter.scala:305)
at org.apache.spark.util.Utils$.tryWithSafeFinallyAndFailureCallbacks(Utils.scala:1496)
at org.apache.spark.sql.execution.datasources.FileFormatWriter$.executeTask(FileFormatWriter.scala:311)
```
Now, I'm blocking on the lack of compute engine JDK 17 support.
Flink has no exactly version which officially support JDK-17 https://issues.apache.org/jira/browse/FLINK-15736
Spark officially support JDK-17 since 3.3.0 https://issues.apache.org/jira/browse/SPARK-33772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] Yikun commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1046397358
@pan3793 Thanks for helps.
> I did a try in this weekend on Android ARM64 machine, with Termux.
Looks like it's a hard way, thanks for your efforts, if you have any more advanced requrement, I can share a temporary arm64 virtual machine for verification. Feel free to ping me if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#discussion_r810836800
##########
File path: .travis.yml
##########
@@ -37,7 +47,9 @@ install:
- ./build/mvn --version
script:
- - ./build/mvn clean install -Dmaven.javadoc.skip=true -V
+ - export MVN_ARGS="-Dmaven.javadoc.skip=true -V -B -ntp -Dorg.slf4j.simpleLogger.defaultLogLevel=warn"
+ - ./build/mvn clean install -DskipTests $MVN_ARGS
+# - ./build/mvn test $MVN_ARGS
Review comment:
Since we have some issues with zookeeper, we can change it to `build/mvn clean -pl kyuubi-common -am` and merge this PR, then fix other issues and enable those module's test later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1046242242
> Yes, I've reduced it a bit by suppressing Maven's network transfer progress but it wasn't enough. I will try by changing Maven's log level to WARN.
>
> But also there is an actual error:
>
> ```
> KyuubiHiveDriverSuite:
>
> *** RUN ABORTED ***
>
> java.lang.IncompatibleClassChangeError: class org.apache.spark.sql.catalyst.plans.logical.DynamicFileFilterWithCardinalityCheck has interface org.apache.spark.sql.catalyst.plans.logical.BinaryNode as super class
> at java.lang.ClassLoader.defineClass1(Native Method)
> at java.lang.ClassLoader.defineClass(ClassLoader.java:756)
> at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
> at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
> ```
>
> It happened in both runs: https://app.travis-ci.com/github/apache/incubator-kyuubi/jobs/559953401 https://app.travis-ci.com/github/apache/incubator-kyuubi/jobs/559934048
It should resolved by https://github.com/apache/incubator-kyuubi/pull/1942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1041431409
Sorry, my fault please try again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 edited a comment on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1046242242
> Yes, I've reduced it a bit by suppressing Maven's network transfer progress but it wasn't enough. I will try by changing Maven's log level to WARN.
>
> But also there is an actual error:
>
> ```
> KyuubiHiveDriverSuite:
>
> *** RUN ABORTED ***
>
> java.lang.IncompatibleClassChangeError: class org.apache.spark.sql.catalyst.plans.logical.DynamicFileFilterWithCardinalityCheck has interface org.apache.spark.sql.catalyst.plans.logical.BinaryNode as super class
> at java.lang.ClassLoader.defineClass1(Native Method)
> at java.lang.ClassLoader.defineClass(ClassLoader.java:756)
> at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
> at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
> ```
>
> It happened in both runs: https://app.travis-ci.com/github/apache/incubator-kyuubi/jobs/559953401 https://app.travis-ci.com/github/apache/incubator-kyuubi/jobs/559934048
It should be resolved by https://github.com/apache/incubator-kyuubi/pull/1942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1044036692
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1918](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a2019ec) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/47b0fecd6add7d49fbcffacf820688695b27e89a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (47b0fec) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1918 +/- ##
============================================
- Coverage 60.93% 60.87% -0.06%
+ Complexity 72 69 -3
============================================
Files 303 302 -1
Lines 14768 14785 +17
Branches 1902 1914 +12
============================================
+ Hits 8999 9001 +2
- Misses 5006 5012 +6
- Partials 763 772 +9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ubi/engine/spark/operation/PlanOnlyStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vUGxhbk9ubHlTdGF0ZW1lbnQuc2NhbGE=) | `62.85% <0.00%> (-13.01%)` | :arrow_down: |
| [...ubi/engine/flink/operation/PlanOnlyStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9mbGluay9vcGVyYXRpb24vUGxhbk9ubHlTdGF0ZW1lbnQuc2NhbGE=) | `78.57% <0.00%> (-5.43%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.06% <0.00%> (-4.82%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `83.48% <0.00%> (-4.75%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/KyuubiSQLException.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9LeXV1YmlTUUxFeGNlcHRpb24uc2NhbGE=) | `92.77% <0.00%> (-1.21%)` | :arrow_down: |
| [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `84.31% <0.00%> (-0.99%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.30% <0.00%> (-0.12%)` | :arrow_down: |
| [...la/org/apache/kyuubi/session/AbstractSession.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0Fic3RyYWN0U2Vzc2lvbi5zY2FsYQ==) | `98.87% <0.00%> (ø)` | |
| [...g/apache/kyuubi/engine/flink/result/Constants.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL3Jlc3VsdC9Db25zdGFudHMuamF2YQ==) | `50.00% <0.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [47b0fec...a2019ec](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1044196979
@SteNicholas Does Flink support linux/arm64?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] martin-g commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1041410766
Now I notice that the last build at TravisCI was 2 months ago - https://app.travis-ci.com/github/apache/incubator-kyuubi.
Does the project still use it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1041431440
also cc @Yikun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] martin-g commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1046565516
Should I leave only the job for testing on ARM64 in .travis.yml ?
AMD64 is tested at Github Actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] martin-g commented on a change in pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#discussion_r810874057
##########
File path: .travis.yml
##########
@@ -37,7 +47,9 @@ install:
- ./build/mvn --version
script:
- - ./build/mvn clean install -Dmaven.javadoc.skip=true -V
+ - export MVN_ARGS="-Dmaven.javadoc.skip=true -V -B -ntp -Dorg.slf4j.simpleLogger.defaultLogLevel=warn"
+ - ./build/mvn clean install -DskipTests $MVN_ARGS
+ - ./build/mvn test $MVN_ARGS -pl kyuubi-common -am
Review comment:
FIxed!
##########
File path: .travis.yml
##########
@@ -29,6 +29,16 @@ scala:
jdk:
- openjdk8
+matrix:
+ include:
+ - name: Linux x86_64
+ arch: amd64
Review comment:
Removed it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1046239940
I did a try in this weekend on Android ARM64 machine.
The brief environment information
```
╲ ▁▂▂▂▁ ╱
▄███████▄
▄██ ███ ██▄
▄███████████▄ OS: Android 11
▄█ ▄▄▄▄▄▄▄▄▄▄▄▄▄ █▄ Device: Lenovo TB-J716F (J716F)
██ █████████████ ██ ROM: TB-J716F_CN_OPEN_USER_Q00209.3_R_ZUI_13.0.430_ST_220113
██ █████████████ ██ Baseband: apq
██ █████████████ ██ Kernel: aarch64 Linux 4.19.152-perf+
██ █████████████ ██ Uptime:
█████████████ CPU: Qualcomm Technologies, Inc KONA
███████████ GPU: Qualcomm Technologies, Inc KONA
██ ██ RAM: 3027MiB / 5667MiB
██ ██
```
And I can only got the JDK-17 provided by the OS package manager `apt`.
```
openjdk version "17-internal" 2021-09-14
OpenJDK Runtime Environment (build 17-internal+0-adhoc..src)
OpenJDK 64-Bit Server VM (build 17-internal+0-adhoc..src, mixed mode)
```
Encounter some issues related to JDK-17, partial fixed but still can not pass all UTs.
Test command:
```
build/mvn install -Dzookeeper.version=3.5.9 -Dmaven.plugin.scalatest.exclude.tags=org.apache.kyuubi.tags.ExtendedSQLTest,org.apache.kyuubi.tags.DeltaTest,org.apache.kyuubi.tags.IcebergTest,org.apache.kyuubi.tags.HudiTest
```
- https://github.com/apache/incubator-kyuubi/pull/1939
- https://github.com/apache/incubator-kyuubi/pull/1940
- https://github.com/apache/incubator-kyuubi/issues/1941
- https://github.com/apache/incubator-kyuubi/pull/1943
The current status,
`kyuubi-flink-sql-engine` failed because of Flink 1.14 depends on`asm-7` which does not support JDK 17.
```
Caused by: org.apache.flink.table.api.ValidationException: Unable to extract a type inference from method:
public java.lang.String LowerUDF.eval(java.lang.String)
at org.apache.flink.table.types.extraction.ExtractionUtils.extractionError(ExtractionUtils.java:362)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractResultMappings(FunctionMappingExtractor.java:183)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractOutputMapping(FunctionMappingExtractor.java:114)
... 29 more
Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 61
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:195)
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:176)
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:162)
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:283)
at org.apache.flink.table.types.extraction.ExtractionUtils.getClassReader(ExtractionUtils.java:747)
at org.apache.flink.table.types.extraction.ExtractionUtils.extractExecutableNames(ExtractionUtils.java:721)
at org.apache.flink.table.types.extraction.ExtractionUtils.extractMethodParameterNames(ExtractionUtils.java:656)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractArgumentNames(FunctionMappingExtractor.java:429)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.lambda$createParameterSignatureExtraction$9(FunctionMappingExtractor.java:367)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.putExtractedResultMappings(FunctionMappingExtractor.java:324)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.collectMethodMappings(FunctionMappingExtractor.java:269)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractResultMappings(FunctionMappingExtractor.java:169)
```
`kyuubi-spark-sql-engine` failed in Delta test with the following stacktrace, passed with `-Dmaven.plugin.scalatest.exclude.tags=org.apache.kyuubi.tags.ExtendedSQLTest,org.apache.kyuubi.tags.DeltaTest,org.apache.kyuubi.tags.IcebergTest,org.apache.kyuubi.tags.HudiTest`
```
Caused by: java.lang.IllegalArgumentException: newLimit > capacity: (84 > 78)
at java.base/java.nio.Buffer.createLimitException(Buffer.java:395)
at java.base/java.nio.Buffer.limit(Buffer.java:369)
at java.base/java.nio.ByteBuffer.limit(ByteBuffer.java:1529)
at java.base/java.nio.MappedByteBuffer.limit(MappedByteBuffer.java:330)
at java.base/java.nio.MappedByteBuffer.limit(MappedByteBuffer.java:73)
at org.xerial.snappy.Snappy.compress(Snappy.java:156)
at org.apache.parquet.hadoop.codec.SnappyCompressor.compress(SnappyCompressor.java:78)
at org.apache.hadoop.io.compress.CompressorStream.compress(CompressorStream.java:81)
at org.apache.hadoop.io.compress.CompressorStream.finish(CompressorStream.java:92)
at org.apache.parquet.hadoop.CodecFactory$HeapBytesCompressor.compress(CodecFactory.java:167)
at org.apache.parquet.hadoop.ColumnChunkPageWriteStore$ColumnChunkPageWriter.writePage(ColumnChunkPageWriteStore.java:168)
at org.apache.parquet.column.impl.ColumnWriterV1.writePage(ColumnWriterV1.java:59)
at org.apache.parquet.column.impl.ColumnWriterBase.writePage(ColumnWriterBase.java:387)
at org.apache.parquet.column.impl.ColumnWriteStoreBase.flush(ColumnWriteStoreBase.java:186)
at org.apache.parquet.column.impl.ColumnWriteStoreV1.flush(ColumnWriteStoreV1.java:29)
at org.apache.parquet.hadoop.InternalParquetRecordWriter.flushRowGroupToStore(InternalParquetRecordWriter.java:185)
at org.apache.parquet.hadoop.InternalParquetRecordWriter.close(InternalParquetRecordWriter.java:124)
at org.apache.parquet.hadoop.ParquetRecordWriter.close(ParquetRecordWriter.java:164)
at org.apache.spark.sql.execution.datasources.parquet.ParquetOutputWriter.close(ParquetOutputWriter.scala:41)
at org.apache.spark.sql.execution.datasources.FileFormatDataWriter.releaseCurrentWriter(FileFormatDataWriter.scala:64)
at org.apache.spark.sql.execution.datasources.FileFormatDataWriter.releaseResources(FileFormatDataWriter.scala:75)
at org.apache.spark.sql.execution.datasources.FileFormatDataWriter.commit(FileFormatDataWriter.scala:105)
at org.apache.spark.sql.execution.datasources.FileFormatWriter$.$anonfun$executeTask$1(FileFormatWriter.scala:305)
at org.apache.spark.util.Utils$.tryWithSafeFinallyAndFailureCallbacks(Utils.scala:1496)
at org.apache.spark.sql.execution.datasources.FileFormatWriter$.executeTask(FileFormatWriter.scala:311)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 edited a comment on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1046239940
I did a try in this weekend on Android ARM64 machine, with Termux.
The brief environment information
```
╲ ▁▂▂▂▁ ╱
▄███████▄
▄██ ███ ██▄
▄███████████▄ OS: Android 11
▄█ ▄▄▄▄▄▄▄▄▄▄▄▄▄ █▄ Device: Lenovo TB-J716F (J716F)
██ █████████████ ██ ROM: TB-J716F_CN_OPEN_USER_Q00209.3_R_ZUI_13.0.430_ST_220113
██ █████████████ ██ Baseband: apq
██ █████████████ ██ Kernel: aarch64 Linux 4.19.152-perf+
██ █████████████ ██ Uptime:
█████████████ CPU: Qualcomm Technologies, Inc KONA
███████████ GPU: Qualcomm Technologies, Inc KONA
██ ██ RAM: 3027MiB / 5667MiB
██ ██
```
And I can only get the JDK 17 provided by the OS package manager `apt`.
```
openjdk version "17-internal" 2021-09-14
OpenJDK Runtime Environment (build 17-internal+0-adhoc..src)
OpenJDK 64-Bit Server VM (build 17-internal+0-adhoc..src, mixed mode)
```
Encounter some issues related to JDK-17, partial fixed but still can not pass all UTs.
Test command:
```
build/mvn install -Dzookeeper.version=3.5.9 -Dmaven.plugin.scalatest.exclude.tags=org.apache.kyuubi.tags.ExtendedSQLTest,org.apache.kyuubi.tags.DeltaTest,org.apache.kyuubi.tags.IcebergTest,org.apache.kyuubi.tags.HudiTest
```
- https://github.com/apache/incubator-kyuubi/pull/1939
- https://github.com/apache/incubator-kyuubi/pull/1940
- https://github.com/apache/incubator-kyuubi/issues/1941
- https://github.com/apache/incubator-kyuubi/pull/1943
The current status,
`kyuubi-flink-sql-engine` failed because of Flink 1.14 depends on`asm-7` which does not support JDK 17.
```
Caused by: org.apache.flink.table.api.ValidationException: Unable to extract a type inference from method:
public java.lang.String LowerUDF.eval(java.lang.String)
at org.apache.flink.table.types.extraction.ExtractionUtils.extractionError(ExtractionUtils.java:362)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractResultMappings(FunctionMappingExtractor.java:183)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractOutputMapping(FunctionMappingExtractor.java:114)
... 29 more
Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 61
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:195)
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:176)
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:162)
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:283)
at org.apache.flink.table.types.extraction.ExtractionUtils.getClassReader(ExtractionUtils.java:747)
at org.apache.flink.table.types.extraction.ExtractionUtils.extractExecutableNames(ExtractionUtils.java:721)
at org.apache.flink.table.types.extraction.ExtractionUtils.extractMethodParameterNames(ExtractionUtils.java:656)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractArgumentNames(FunctionMappingExtractor.java:429)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.lambda$createParameterSignatureExtraction$9(FunctionMappingExtractor.java:367)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.putExtractedResultMappings(FunctionMappingExtractor.java:324)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.collectMethodMappings(FunctionMappingExtractor.java:269)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractResultMappings(FunctionMappingExtractor.java:169)
```
`kyuubi-spark-sql-engine` failed in Delta test with the following stacktrace, passed with `-Dmaven.plugin.scalatest.exclude.tags=org.apache.kyuubi.tags.ExtendedSQLTest,org.apache.kyuubi.tags.DeltaTest,org.apache.kyuubi.tags.IcebergTest,org.apache.kyuubi.tags.HudiTest`
```
Caused by: java.lang.IllegalArgumentException: newLimit > capacity: (84 > 78)
at java.base/java.nio.Buffer.createLimitException(Buffer.java:395)
at java.base/java.nio.Buffer.limit(Buffer.java:369)
at java.base/java.nio.ByteBuffer.limit(ByteBuffer.java:1529)
at java.base/java.nio.MappedByteBuffer.limit(MappedByteBuffer.java:330)
at java.base/java.nio.MappedByteBuffer.limit(MappedByteBuffer.java:73)
at org.xerial.snappy.Snappy.compress(Snappy.java:156)
at org.apache.parquet.hadoop.codec.SnappyCompressor.compress(SnappyCompressor.java:78)
at org.apache.hadoop.io.compress.CompressorStream.compress(CompressorStream.java:81)
at org.apache.hadoop.io.compress.CompressorStream.finish(CompressorStream.java:92)
at org.apache.parquet.hadoop.CodecFactory$HeapBytesCompressor.compress(CodecFactory.java:167)
at org.apache.parquet.hadoop.ColumnChunkPageWriteStore$ColumnChunkPageWriter.writePage(ColumnChunkPageWriteStore.java:168)
at org.apache.parquet.column.impl.ColumnWriterV1.writePage(ColumnWriterV1.java:59)
at org.apache.parquet.column.impl.ColumnWriterBase.writePage(ColumnWriterBase.java:387)
at org.apache.parquet.column.impl.ColumnWriteStoreBase.flush(ColumnWriteStoreBase.java:186)
at org.apache.parquet.column.impl.ColumnWriteStoreV1.flush(ColumnWriteStoreV1.java:29)
at org.apache.parquet.hadoop.InternalParquetRecordWriter.flushRowGroupToStore(InternalParquetRecordWriter.java:185)
at org.apache.parquet.hadoop.InternalParquetRecordWriter.close(InternalParquetRecordWriter.java:124)
at org.apache.parquet.hadoop.ParquetRecordWriter.close(ParquetRecordWriter.java:164)
at org.apache.spark.sql.execution.datasources.parquet.ParquetOutputWriter.close(ParquetOutputWriter.scala:41)
at org.apache.spark.sql.execution.datasources.FileFormatDataWriter.releaseCurrentWriter(FileFormatDataWriter.scala:64)
at org.apache.spark.sql.execution.datasources.FileFormatDataWriter.releaseResources(FileFormatDataWriter.scala:75)
at org.apache.spark.sql.execution.datasources.FileFormatDataWriter.commit(FileFormatDataWriter.scala:105)
at org.apache.spark.sql.execution.datasources.FileFormatWriter$.$anonfun$executeTask$1(FileFormatWriter.scala:305)
at org.apache.spark.util.Utils$.tryWithSafeFinallyAndFailureCallbacks(Utils.scala:1496)
at org.apache.spark.sql.execution.datasources.FileFormatWriter$.executeTask(FileFormatWriter.scala:311)
```
Now, I'm blocking on the lack of compute engine JDK 17 support.
Flink has no exactly version which officially support JDK 17 https://issues.apache.org/jira/browse/FLINK-15736
Spark officially support JDK 17 since 3.3.0 https://issues.apache.org/jira/browse/SPARK-33772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1041423097
Manually turned on Travis on PRs, can you send commit with '--allow-empty' to trigger CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 edited a comment on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1046239940
I did a try in this weekend on Android ARM64 machine.
The brief environment information
```
╲ ▁▂▂▂▁ ╱
▄███████▄
▄██ ███ ██▄
▄███████████▄ OS: Android 11
▄█ ▄▄▄▄▄▄▄▄▄▄▄▄▄ █▄ Device: Lenovo TB-J716F (J716F)
██ █████████████ ██ ROM: TB-J716F_CN_OPEN_USER_Q00209.3_R_ZUI_13.0.430_ST_220113
██ █████████████ ██ Baseband: apq
██ █████████████ ██ Kernel: aarch64 Linux 4.19.152-perf+
██ █████████████ ██ Uptime:
█████████████ CPU: Qualcomm Technologies, Inc KONA
███████████ GPU: Qualcomm Technologies, Inc KONA
██ ██ RAM: 3027MiB / 5667MiB
██ ██
```
And I can only get the JDK-17 provided by the OS package manager `apt`.
```
openjdk version "17-internal" 2021-09-14
OpenJDK Runtime Environment (build 17-internal+0-adhoc..src)
OpenJDK 64-Bit Server VM (build 17-internal+0-adhoc..src, mixed mode)
```
Encounter some issues related to JDK-17, partial fixed but still can not pass all UTs.
Test command:
```
build/mvn install -Dzookeeper.version=3.5.9 -Dmaven.plugin.scalatest.exclude.tags=org.apache.kyuubi.tags.ExtendedSQLTest,org.apache.kyuubi.tags.DeltaTest,org.apache.kyuubi.tags.IcebergTest,org.apache.kyuubi.tags.HudiTest
```
- https://github.com/apache/incubator-kyuubi/pull/1939
- https://github.com/apache/incubator-kyuubi/pull/1940
- https://github.com/apache/incubator-kyuubi/issues/1941
- https://github.com/apache/incubator-kyuubi/pull/1943
The current status,
`kyuubi-flink-sql-engine` failed because of Flink 1.14 depends on`asm-7` which does not support JDK 17.
```
Caused by: org.apache.flink.table.api.ValidationException: Unable to extract a type inference from method:
public java.lang.String LowerUDF.eval(java.lang.String)
at org.apache.flink.table.types.extraction.ExtractionUtils.extractionError(ExtractionUtils.java:362)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractResultMappings(FunctionMappingExtractor.java:183)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractOutputMapping(FunctionMappingExtractor.java:114)
... 29 more
Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 61
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:195)
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:176)
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:162)
at org.apache.flink.shaded.asm7.org.objectweb.asm.ClassReader.<init>(ClassReader.java:283)
at org.apache.flink.table.types.extraction.ExtractionUtils.getClassReader(ExtractionUtils.java:747)
at org.apache.flink.table.types.extraction.ExtractionUtils.extractExecutableNames(ExtractionUtils.java:721)
at org.apache.flink.table.types.extraction.ExtractionUtils.extractMethodParameterNames(ExtractionUtils.java:656)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractArgumentNames(FunctionMappingExtractor.java:429)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.lambda$createParameterSignatureExtraction$9(FunctionMappingExtractor.java:367)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.putExtractedResultMappings(FunctionMappingExtractor.java:324)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.collectMethodMappings(FunctionMappingExtractor.java:269)
at org.apache.flink.table.types.extraction.FunctionMappingExtractor.extractResultMappings(FunctionMappingExtractor.java:169)
```
`kyuubi-spark-sql-engine` failed in Delta test with the following stacktrace, passed with `-Dmaven.plugin.scalatest.exclude.tags=org.apache.kyuubi.tags.ExtendedSQLTest,org.apache.kyuubi.tags.DeltaTest,org.apache.kyuubi.tags.IcebergTest,org.apache.kyuubi.tags.HudiTest`
```
Caused by: java.lang.IllegalArgumentException: newLimit > capacity: (84 > 78)
at java.base/java.nio.Buffer.createLimitException(Buffer.java:395)
at java.base/java.nio.Buffer.limit(Buffer.java:369)
at java.base/java.nio.ByteBuffer.limit(ByteBuffer.java:1529)
at java.base/java.nio.MappedByteBuffer.limit(MappedByteBuffer.java:330)
at java.base/java.nio.MappedByteBuffer.limit(MappedByteBuffer.java:73)
at org.xerial.snappy.Snappy.compress(Snappy.java:156)
at org.apache.parquet.hadoop.codec.SnappyCompressor.compress(SnappyCompressor.java:78)
at org.apache.hadoop.io.compress.CompressorStream.compress(CompressorStream.java:81)
at org.apache.hadoop.io.compress.CompressorStream.finish(CompressorStream.java:92)
at org.apache.parquet.hadoop.CodecFactory$HeapBytesCompressor.compress(CodecFactory.java:167)
at org.apache.parquet.hadoop.ColumnChunkPageWriteStore$ColumnChunkPageWriter.writePage(ColumnChunkPageWriteStore.java:168)
at org.apache.parquet.column.impl.ColumnWriterV1.writePage(ColumnWriterV1.java:59)
at org.apache.parquet.column.impl.ColumnWriterBase.writePage(ColumnWriterBase.java:387)
at org.apache.parquet.column.impl.ColumnWriteStoreBase.flush(ColumnWriteStoreBase.java:186)
at org.apache.parquet.column.impl.ColumnWriteStoreV1.flush(ColumnWriteStoreV1.java:29)
at org.apache.parquet.hadoop.InternalParquetRecordWriter.flushRowGroupToStore(InternalParquetRecordWriter.java:185)
at org.apache.parquet.hadoop.InternalParquetRecordWriter.close(InternalParquetRecordWriter.java:124)
at org.apache.parquet.hadoop.ParquetRecordWriter.close(ParquetRecordWriter.java:164)
at org.apache.spark.sql.execution.datasources.parquet.ParquetOutputWriter.close(ParquetOutputWriter.scala:41)
at org.apache.spark.sql.execution.datasources.FileFormatDataWriter.releaseCurrentWriter(FileFormatDataWriter.scala:64)
at org.apache.spark.sql.execution.datasources.FileFormatDataWriter.releaseResources(FileFormatDataWriter.scala:75)
at org.apache.spark.sql.execution.datasources.FileFormatDataWriter.commit(FileFormatDataWriter.scala:105)
at org.apache.spark.sql.execution.datasources.FileFormatWriter$.$anonfun$executeTask$1(FileFormatWriter.scala:305)
at org.apache.spark.util.Utils$.tryWithSafeFinallyAndFailureCallbacks(Utils.scala:1496)
at org.apache.spark.sql.execution.datasources.FileFormatWriter$.executeTask(FileFormatWriter.scala:311)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1046401040
IMO, we can merge this PR first and let the arm64 ci do the work. And then, we can fix those tests case by case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1044036692
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1918](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (01e3b94) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/47b0fecd6add7d49fbcffacf820688695b27e89a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (47b0fec) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 01e3b94 differs from pull request most recent head a2019ec. Consider uploading reports for the commit a2019ec to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1918 +/- ##
============================================
+ Coverage 60.93% 60.96% +0.02%
Complexity 72 72
============================================
Files 303 304 +1
Lines 14768 14798 +30
Branches 1902 1909 +7
============================================
+ Hits 8999 9021 +22
- Misses 5006 5009 +3
- Partials 763 768 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.06% <0.00%> (-4.82%)` | :arrow_down: |
| [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `84.31% <0.00%> (-0.99%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `87.25% <0.00%> (-0.99%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.27% <0.00%> (-0.15%)` | :arrow_down: |
| [...g/apache/kyuubi/engine/flink/result/Constants.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL3Jlc3VsdC9Db25zdGFudHMuamF2YQ==) | `50.00% <0.00%> (ø)` | |
| [...che/kyuubi/engine/trino/operation/GetColumns.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9HZXRDb2x1bW5zLnNjYWxh) | `88.88% <0.00%> (ø)` | |
| [...kyuubi/engine/trino/operation/TrinoOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9Ucmlub09wZXJhdGlvbi5zY2FsYQ==) | `50.94% <0.00%> (+1.92%)` | :arrow_up: |
| [...engine/trino/operation/TrinoOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9Ucmlub09wZXJhdGlvbk1hbmFnZXIuc2NhbGE=) | `95.00% <0.00%> (+10.78%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [47b0fec...a2019ec](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] martin-g commented on a change in pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#discussion_r810850256
##########
File path: .travis.yml
##########
@@ -37,7 +47,9 @@ install:
- ./build/mvn --version
script:
- - ./build/mvn clean install -Dmaven.javadoc.skip=true -V
+ - export MVN_ARGS="-Dmaven.javadoc.skip=true -V -B -ntp -Dorg.slf4j.simpleLogger.defaultLogLevel=warn"
+ - ./build/mvn clean install -DskipTests $MVN_ARGS
+# - ./build/mvn test $MVN_ARGS
Review comment:
+1 from me on this suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1044036692
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1918](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a2019ec) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/47b0fecd6add7d49fbcffacf820688695b27e89a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (47b0fec) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a2019ec differs from pull request most recent head 4700c3e. Consider uploading reports for the commit 4700c3e to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1918 +/- ##
============================================
- Coverage 60.93% 60.87% -0.06%
+ Complexity 72 69 -3
============================================
Files 303 302 -1
Lines 14768 14785 +17
Branches 1902 1914 +12
============================================
+ Hits 8999 9001 +2
- Misses 5006 5012 +6
- Partials 763 772 +9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ubi/engine/spark/operation/PlanOnlyStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vUGxhbk9ubHlTdGF0ZW1lbnQuc2NhbGE=) | `62.85% <0.00%> (-13.01%)` | :arrow_down: |
| [...ubi/engine/flink/operation/PlanOnlyStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9mbGluay9vcGVyYXRpb24vUGxhbk9ubHlTdGF0ZW1lbnQuc2NhbGE=) | `78.57% <0.00%> (-5.43%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.06% <0.00%> (-4.82%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `83.48% <0.00%> (-4.75%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/KyuubiSQLException.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9LeXV1YmlTUUxFeGNlcHRpb24uc2NhbGE=) | `92.77% <0.00%> (-1.21%)` | :arrow_down: |
| [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `84.31% <0.00%> (-0.99%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.30% <0.00%> (-0.12%)` | :arrow_down: |
| [...la/org/apache/kyuubi/session/AbstractSession.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0Fic3RyYWN0U2Vzc2lvbi5zY2FsYQ==) | `98.87% <0.00%> (ø)` | |
| [...g/apache/kyuubi/engine/flink/result/Constants.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1mbGluay1zcWwtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2ZsaW5rL3Jlc3VsdC9Db25zdGFudHMuamF2YQ==) | `50.00% <0.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [47b0fec...4700c3e](https://codecov.io/gh/apache/incubator-kyuubi/pull/1918?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#discussion_r810770785
##########
File path: .travis.yml
##########
@@ -37,7 +47,7 @@ install:
- ./build/mvn --version
script:
- - ./build/mvn clean install -Dmaven.javadoc.skip=true -V
+ - ./build/mvn clean install -Dmaven.javadoc.skip=true -V -B -ntp -Dorg.slf4j.simpleLogger.defaultLogLevel=warn
Review comment:
How about test compile on ARM64 first? Then we can enable test moudle by moudle after fixing?
```suggestion
- export MVN_ARGS="-Dmaven.javadoc.skip=true -V -B -ntp -Dorg.slf4j.simpleLogger.defaultLogLevel=warn"
- ./build/mvn clean install -DskipTests $MVN_ARGS
# - ./build/mvn test $MVN_ARGS
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1918: Build and test on Linux ARM64
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1918:
URL: https://github.com/apache/incubator-kyuubi/pull/1918#issuecomment-1046682480
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org