You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "ruanwenjun (via GitHub)" <gi...@apache.org> on 2023/08/29 04:15:26 UTC
[GitHub] [dolphinscheduler] ruanwenjun opened a new pull request, #14827: Add workflowInstanceHost and taskInstanceHost in ITaskInstanceExecutionEvent
ruanwenjun opened a new pull request, #14827:
URL: https://github.com/apache/dolphinscheduler/pull/14827
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14827: Add workflowInstanceHost and taskInstanceHost in ITaskInstanceExecutionEvent
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14827:
URL: https://github.com/apache/dolphinscheduler/pull/14827#issuecomment-1696761360
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=14827)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14827&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14827&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14827&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14827&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14827&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14827&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14827&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14827&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14827&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14827&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14827&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14827&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14827&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14827&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #14827: Add workflowInstanceHost and taskInstanceHost in ITaskInstanceExecutionEvent
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #14827:
URL: https://github.com/apache/dolphinscheduler/pull/14827#issuecomment-1696755048
## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14827?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#14827](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14827?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4a11347) into [dev](https://app.codecov.io/gh/apache/dolphinscheduler/commit/9e60632201a031dffe7b21cefcc3bc550edbe608?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9e60632) will **decrease** coverage by `0.03%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 4a11347 differs from pull request most recent head a52c44d. Consider uploading reports for the commit a52c44d to get more accurate results
```diff
@@ Coverage Diff @@
## dev #14827 +/- ##
============================================
- Coverage 38.92% 38.90% -0.03%
+ Complexity 4598 4595 -3
============================================
Files 1232 1232
Lines 43249 43222 -27
Branches 4789 4771 -18
============================================
- Hits 16834 16814 -20
+ Misses 24548 24543 -5
+ Partials 1867 1865 -2
```
| [Files Changed](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...duler/server/master/processor/queue/TaskEvent.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza0V2ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ge/LogicTaskInstanceExecuteRunningEventSender.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvbWVzc2FnZS9Mb2dpY1Rhc2tJbnN0YW5jZUV4ZWN1dGVSdW5uaW5nRXZlbnRTZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...e/LogicTaskInstanceExecutionFinishEventSender.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvbWVzc2FnZS9Mb2dpY1Rhc2tJbnN0YW5jZUV4ZWN1dGlvbkZpbmlzaEV2ZW50U2VuZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...uler/server/worker/message/MessageRetryRunner.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci13b3JrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9tZXNzYWdlL01lc3NhZ2VSZXRyeVJ1bm5lci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...essage/TaskInstanceExecutionFinishEventSender.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci13b3JrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9tZXNzYWdlL1Rhc2tJbnN0YW5jZUV4ZWN1dGlvbkZpbmlzaEV2ZW50U2VuZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ge/TaskInstanceExecutionInfoUpdateEventSender.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci13b3JrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9tZXNzYWdlL1Rhc2tJbnN0YW5jZUV4ZWN1dGlvbkluZm9VcGRhdGVFdmVudFNlbmRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ssage/TaskInstanceExecutionRunningEventSender.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci13b3JrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9tZXNzYWdlL1Rhc2tJbnN0YW5jZUV4ZWN1dGlvblJ1bm5pbmdFdmVudFNlbmRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
... and [26 files with indirect coverage changes](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14827/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun merged pull request #14827: Add workflowInstanceHost and taskInstanceHost in ITaskInstanceExecutionEvent
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun merged PR #14827:
URL: https://github.com/apache/dolphinscheduler/pull/14827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14827: Add workflowInstanceHost and taskInstanceHost in ITaskInstanceExecutionEvent
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14827:
URL: https://github.com/apache/dolphinscheduler/pull/14827#issuecomment-1696761651
Please retry analysis of this Pull-Request directly on [SonarCloud](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14827).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org