You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by uzmijnlm <gi...@git.apache.org> on 2018/06/29 03:42:27 UTC

[GitHub] spark pull request #21665: [SPARK-24688][examples]Modify the comments about ...

GitHub user uzmijnlm opened a pull request:

    https://github.com/apache/spark/pull/21665

    [SPARK-24688][examples]Modify the comments about LabeledPoint

    ## What changes were proposed in this pull request?
    
    An RDD is created using LabeledPoint, but the comment is like #LabeledPoint(feature, label).
    Although in the method ChiSquareTest.test, the second parameter is feature and the third parameter is label, it it better to write label in front of feature here because if an RDD is created using LabeldPoint, what we get are actually (label, feature) pairs.
    Now it is changed as LabeledPoint(label, feature).
    
    The comments in Scala and Java example have the same typos.
    
    ## How was this patch tested?
    
    tested
    
    https://issues.apache.org/jira/browse/SPARK-24688
    
    Author: Weizhe Huang 492816239@qq.com
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uzmijnlm/spark my_change

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21665.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21665
    
----
commit 79e414f2af16bc032e9dcb7eb1f4ab4da95c1fff
Author: Huangweizhe <hu...@...>
Date:   2018-06-29T03:29:50Z

    Modify the comments about LabeledPoint

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21665: [SPARK-24688][examples]Modify the comments about Labeled...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/21665
  
    @uzmijnlm I can take this over and add additional changes, if you're busy. Is that OK?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21665: [SPARK-24688][examples]Modify the comments about Labeled...

Posted by uzmijnlm <gi...@git.apache.org>.

Github user uzmijnlm commented on the issue:

    https://github.com/apache/spark/pull/21665
  
    ok to test


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21665: [SPARK-24688][examples]Modify the comments about Labeled...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21665
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21665: [SPARK-24688][examples]Modify the comments about Labeled...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21665
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21665: [SPARK-24688][examples]Modify the comments about Labeled...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21665
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21665: [SPARK-24688][examples]Modify the comments about Labeled...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21665
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21665: [SPARK-24688][examples]Modify the comments about Labeled...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21665
  
    **[Test build #4287 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4287/testReport)** for PR 21665 at commit [`79e414f`](https://github.com/apache/spark/commit/79e414f2af16bc032e9dcb7eb1f4ab4da95c1fff).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21665: [SPARK-24688][examples]Modify the comments about Labeled...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/21665
  
    Actually, the other cases aren't referring to a LabeledPoint, so I'll leave them. This is fine, and I'll merge it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21665: [SPARK-24688][examples]Modify the comments about Labeled...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21665
  
    **[Test build #4287 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4287/testReport)** for PR 21665 at commit [`79e414f`](https://github.com/apache/spark/commit/79e414f2af16bc032e9dcb7eb1f4ab4da95c1fff).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org