[GitHub] brodybits opened a new pull request #577: Other target-dir remapping fixes

[GitBox <gi...@apache.org>]

brodybits opened a new pull request #577: Other target-dir remapping fixes
URL: https://github.com/apache/cordova-android/pull/577
 
 
   Use startsWith instead of `includes` to check for remapping of `target-dir` that starts with `libs` or `src/main`
   
   (Followup to PR #572)
   
   Discovered while reviewing code related to change proposed in PR #572.
   
   I think this is a very rare case that is not covered by the unit tests. I don't think we should delay 7.1.4 hotfix to get this fix in.
   
   I am not sure whether or not it is worth the time to add unit tests to cover this edge case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org