[GitHub] [kafka] acsaki commented on pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

[GitBox <gi...@apache.org>]

acsaki commented on PR #12179:
URL: https://github.com/apache/kafka/pull/12179#issuecomment-1142294491

   > @acsaki , we haven't get your response for some days, do you need help on it? We can co-author with you to address the comments and fix the tests. Please let me know. Thank you.
   
   Hi @showuon  , Thank you! I wasn't working for a few days.. Thanks for all the suggestions (@SamBarker  and @tombentley too), I'm writing some more tests to capture the intended behavior, which is as I understood:
   - when reauth is disabled (when max reauth ms is NOT set), leave ReauthInfo#sessionExpirationTimeNanos as null but return millis until the token expires in  SaslAuthenticateResponse's sessionLifetimeMs
   - when reauth is enabled and the token expires after max reauth time, set sessionExpirationTimeNanos to when the reauth is due and also return sessionLifetimeMs in the  SaslAuthenticateResponse accordingly
   - when reauth is enabled and the token expires before max reauth time, set sessionExpirationTimeNanos to when the token expires and also return sessionLifetimeMs in the  SaslAuthenticateResponse accordingly.
   
   SaslServerAuthenticatorTest does not lend itself easily to testing all these, oh well. :)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org