You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/17 19:21:39 UTC
[GitHub] [incubator-superset] john-bodley commented on a change in pull
request #9316: fix: remove character set and collate column info by default
john-bodley commented on a change in pull request #9316: fix: remove character set and collate column info by default
URL: https://github.com/apache/incubator-superset/pull/9316#discussion_r393914511
##########
File path: superset/db_engine_specs/base.py
##########
@@ -911,13 +912,18 @@ def column_datatype_to_string(
) -> str:
"""
Convert sqlalchemy column type to string representation.
- Can be overridden to remove unnecessary details, especially
- collation info (see mysql, mssql).
+ By default removes collation and character encoding info to avoid unnecessarily
+ long datatypes.
:param sqla_column_type: SqlAlchemy column type
:param dialect: Sqlalchemy dialect
:return: Compiled column type
"""
+ sqla_column_type = sqla_column_type.copy()
Review comment:
I've never seen this pattern of copying a variable and renaming it to itself, but I guess it works for this purpose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org