You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Nicolas Spiegelberg (Created) (JIRA)" <ji...@apache.org> on 2011/11/16 22:27:52 UTC
[jira] [Created] (HBASE-4802) Disable show table metrics in bulk
loader
Disable show table metrics in bulk loader
-----------------------------------------
Key: HBASE-4802
URL: https://issues.apache.org/jira/browse/HBASE-4802
Project: HBase
Issue Type: Bug
Reporter: Nicolas Spiegelberg
Assignee: Nicolas Spiegelberg
Priority: Trivial
Fix For: 0.94.0
During bulk load, the Configuration object may be set to null. This caused an NPE in per-CF metrics because it consults the Configuration to determine whether to show the Table name. Need to add simple change to allow the conf to be null & not specify table name in that instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4802) Disable show table metrics in bulk
loader
Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151619#comment-13151619 ]
Nicolas Spiegelberg commented on HBASE-4802:
--------------------------------------------
correct. I am adding the null check 1 level deeper in the stack under SchemaMetrics.configureGlobally(). This will ensure that setUseTableName(false) is called.
> Disable show table metrics in bulk loader
> -----------------------------------------
>
> Key: HBASE-4802
> URL: https://issues.apache.org/jira/browse/HBASE-4802
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Liyin Tang
> Priority: Trivial
> Fix For: 0.94.0
>
> Attachments: HBASE-4802.patch
>
>
> During bulk load, the Configuration object may be set to null. This caused an NPE in per-CF metrics because it consults the Configuration to determine whether to show the Table name. Need to add simple change to allow the conf to be null & not specify table name in that instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4802) Disable show table metrics in bulk
loader
Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151530#comment-13151530 ]
Nicolas Spiegelberg commented on HBASE-4802:
--------------------------------------------
Part of 89-fb to 92 port. See r1182037
> Disable show table metrics in bulk loader
> -----------------------------------------
>
> Key: HBASE-4802
> URL: https://issues.apache.org/jira/browse/HBASE-4802
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Priority: Trivial
> Fix For: 0.94.0
>
> Attachments: HBASE-4802.patch
>
>
> During bulk load, the Configuration object may be set to null. This caused an NPE in per-CF metrics because it consults the Configuration to determine whether to show the Table name. Need to add simple change to allow the conf to be null & not specify table name in that instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4802) Disable show table metrics in bulk
loader
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4802:
-------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks for patch Liyin.
> Disable show table metrics in bulk loader
> -----------------------------------------
>
> Key: HBASE-4802
> URL: https://issues.apache.org/jira/browse/HBASE-4802
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Liyin Tang
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-4802.patch
>
>
> During bulk load, the Configuration object may be set to null. This caused an NPE in per-CF metrics because it consults the Configuration to determine whether to show the Table name. Need to add simple change to allow the conf to be null & not specify table name in that instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4802) Disable show table metrics in bulk
loader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465150#comment-13465150 ]
Hudson commented on HBASE-4802:
-------------------------------
Integrated in HBase-TRUNK #3386 (See [https://builds.apache.org/job/HBase-TRUNK/3386/])
HBASE-4802 Disable show table metrics in bulk loader (Revision 1391206)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaConfigured.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java
> Disable show table metrics in bulk loader
> -----------------------------------------
>
> Key: HBASE-4802
> URL: https://issues.apache.org/jira/browse/HBASE-4802
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Liyin Tang
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-4802.patch
>
>
> During bulk load, the Configuration object may be set to null. This caused an NPE in per-CF metrics because it consults the Configuration to determine whether to show the Table name. Need to add simple change to allow the conf to be null & not specify table name in that instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4802) Disable show table metrics in bulk
loader
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4802:
---------------------------------------
Assignee: Liyin Tang (was: Nicolas Spiegelberg)
Status: Patch Available (was: Open)
> Disable show table metrics in bulk loader
> -----------------------------------------
>
> Key: HBASE-4802
> URL: https://issues.apache.org/jira/browse/HBASE-4802
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Liyin Tang
> Priority: Trivial
> Fix For: 0.94.0
>
> Attachments: HBASE-4802.patch
>
>
> During bulk load, the Configuration object may be set to null. This caused an NPE in per-CF metrics because it consults the Configuration to determine whether to show the Table name. Need to add simple change to allow the conf to be null & not specify table name in that instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4802) Disable show table metrics in bulk
loader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465226#comment-13465226 ]
Hudson commented on HBASE-4802:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #196 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/196/])
HBASE-4802 Disable show table metrics in bulk loader (Revision 1391206)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaConfigured.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java
> Disable show table metrics in bulk loader
> -----------------------------------------
>
> Key: HBASE-4802
> URL: https://issues.apache.org/jira/browse/HBASE-4802
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Liyin Tang
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-4802.patch
>
>
> During bulk load, the Configuration object may be set to null. This caused an NPE in per-CF metrics because it consults the Configuration to determine whether to show the Table name. Need to add simple change to allow the conf to be null & not specify table name in that instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4802) Disable show table metrics in bulk
loader
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234930#comment-13234930 ]
Lars Hofhansl commented on HBASE-4802:
--------------------------------------
Should we commit this?
> Disable show table metrics in bulk loader
> -----------------------------------------
>
> Key: HBASE-4802
> URL: https://issues.apache.org/jira/browse/HBASE-4802
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Liyin Tang
> Priority: Trivial
> Fix For: 0.94.0
>
> Attachments: HBASE-4802.patch
>
>
> During bulk load, the Configuration object may be set to null. This caused an NPE in per-CF metrics because it consults the Configuration to determine whether to show the Table name. Need to add simple change to allow the conf to be null & not specify table name in that instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4802) Disable show table metrics in bulk
loader
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151615#comment-13151615 ]
Hadoop QA commented on HBASE-4802:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12503953/HBASE-4802.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated -163 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 51 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/268//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/268//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/268//console
This message is automatically generated.
> Disable show table metrics in bulk loader
> -----------------------------------------
>
> Key: HBASE-4802
> URL: https://issues.apache.org/jira/browse/HBASE-4802
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Liyin Tang
> Priority: Trivial
> Fix For: 0.94.0
>
> Attachments: HBASE-4802.patch
>
>
> During bulk load, the Configuration object may be set to null. This caused an NPE in per-CF metrics because it consults the Configuration to determine whether to show the Table name. Need to add simple change to allow the conf to be null & not specify table name in that instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4802) Disable show table metrics in bulk
loader
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4802:
---------------------------------
Fix Version/s: (was: 0.94.0)
0.96.0
Moving out of 0.94. Pull back if you disagree.
> Disable show table metrics in bulk loader
> -----------------------------------------
>
> Key: HBASE-4802
> URL: https://issues.apache.org/jira/browse/HBASE-4802
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Liyin Tang
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-4802.patch
>
>
> During bulk load, the Configuration object may be set to null. This caused an NPE in per-CF metrics because it consults the Configuration to determine whether to show the Table name. Need to add simple change to allow the conf to be null & not specify table name in that instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4802) Disable show table metrics in bulk
loader
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4802:
---------------------------------------
Attachment: HBASE-4802.patch
> Disable show table metrics in bulk loader
> -----------------------------------------
>
> Key: HBASE-4802
> URL: https://issues.apache.org/jira/browse/HBASE-4802
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Priority: Trivial
> Fix For: 0.94.0
>
> Attachments: HBASE-4802.patch
>
>
> During bulk load, the Configuration object may be set to null. This caused an NPE in per-CF metrics because it consults the Configuration to determine whether to show the Table name. Need to add simple change to allow the conf to be null & not specify table name in that instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4802) Disable show table metrics in bulk
loader
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151592#comment-13151592 ]
stack commented on HBASE-4802:
------------------------------
Is this right Nicolas? You add a null check but at same time are removing a null check.
> Disable show table metrics in bulk loader
> -----------------------------------------
>
> Key: HBASE-4802
> URL: https://issues.apache.org/jira/browse/HBASE-4802
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Liyin Tang
> Priority: Trivial
> Fix For: 0.94.0
>
> Attachments: HBASE-4802.patch
>
>
> During bulk load, the Configuration object may be set to null. This caused an NPE in per-CF metrics because it consults the Configuration to determine whether to show the Table name. Need to add simple change to allow the conf to be null & not specify table name in that instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira