You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/05 03:05:40 UTC
[GitHub] [flink] KurtYoung commented on a change in pull request #10059:
[FLINK-14543][table] Support partition for temporary table
KurtYoung commented on a change in pull request #10059: [FLINK-14543][table] Support partition for temporary table
URL: https://github.com/apache/flink/pull/10059#discussion_r342365819
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/descriptors/ConnectTableDescriptor.java
##########
@@ -136,14 +137,24 @@ public void createTemporaryTable(String path) {
" use registerTableSource/registerTableSink/registerTableSourceAndSink.");
}
+ Map<String, String> properties = new HashMap<>(toProperties());
+
+ // handle schema
Map<String, String> schemaProperties = schemaDescriptor.toProperties();
TableSchema tableSchema = getTableSchema(schemaProperties);
-
- Map<String, String> properties = new HashMap<>(toProperties());
schemaProperties.keySet().forEach(properties::remove);
+ // handle partition keys
+ DescriptorProperties descriptor = new DescriptorProperties();
Review comment:
I'm not an expert of descriptors, but this logic dealing with partition keys seems tedious to me. Should we `new DescriptorProperties` twice and add/delete properties back and forth?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services