You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/11/13 14:00:12 UTC
[GitHub] [incubator-echarts] leorigon opened a new issue #13618: Allow the use of alignWithLabel prop inside splitLine type
leorigon opened a new issue #13618:
URL: https://github.com/apache/incubator-echarts/issues/13618
### Version
4.9.0
### Steps to reproduce
Before of the types definitions, at old versions, we could be use the `alignWithLabel` as property of other objects inside charts. For example, at `xAxis.splitLine.alignWithLabel`. This is necessary to align the grid background with ticks labels when we use category instead values on the axis. It's work fine, like to example, but the typescript compiler throw an error because this object isn't declared on the `splitLine` type.
example:
```
splitLine: {
show: true,
// @ts-ignore It's works, but typescript reclaim! :(
alignWithLabel: true,
lineStyle: {
type: 'solid',
opacity: 0.2,
color: props.color || 'red'
},
```
On the docs today, I have noted this property was removed.
### What is expected?
Allow alignWithLabel on the splitLine object.
### What is actually happening?
TypeScript thrown an error, but the option works correctly.
<!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
<!-- This issue is in English. DO NOT REMOVE -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on issue #13618: Allow the use of alignWithLabel prop inside splitLine type
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #13618:
URL: https://github.com/apache/incubator-echarts/issues/13618#issuecomment-727737157
`alignWithLabel` should be a property in `axisTick`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on issue #13618: Allow the use of alignWithLabel prop inside splitLine type
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #13618:
URL: https://github.com/apache/incubator-echarts/issues/13618#issuecomment-728653142
@leorigon . Understand, I think it's our fault on doc and types. Will fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13618: Allow the use of alignWithLabel prop inside splitLine type
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #13618:
URL: https://github.com/apache/incubator-echarts/issues/13618#issuecomment-726780040
Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.
In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer.
If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical question.
If you are interested in the project, you may also subscribe our [mailing list](https://echarts.apache.org/en/maillist.html).
Have a nice day! 🍵
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] leorigon commented on issue #13618: Allow the use of alignWithLabel prop inside splitLine type
Posted by GitBox <gi...@apache.org>.
leorigon commented on issue #13618:
URL: https://github.com/apache/incubator-echarts/issues/13618#issuecomment-728163642
@pissang
> `alignWithLabel` should be a property in `axisTick`
When I remove `alignWithLabel` from `splitLine` and I pass only `axistick`:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org