You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/08/17 10:34:47 UTC
[GitHub] [incubator-pekko-http] pjfanning opened a new issue, #304: headers.scala case classes have package private constructors - Scala 3 enforces this
pjfanning opened a new issue, #304:
URL: https://github.com/apache/incubator-pekko-http/issues/304
For some reason, Scala 2 does not seem to allow public access to package private constructors but Scala 3 enforces it.
We also had to relax the scope on 2 constructors to allow pekko-connectors to compile with Scala 3.
https://github.com/apache/incubator-pekko-http/pull/178
It turns out that Tapir also uses these exact same constructors but Tapir is in its own package. Tapir recently added Pekko HTTP support but didn't add Scala 3 support for Pekko HTTP (https://github.com/softwaremill/tapir/issues/3114).
Should we start making these constructors (see https://github.com/apache/incubator-pekko-http/pull/178) public?
If so, should we backport to 1.0.1 even though this will probably affect binary compatibility?
Adding a hacky org.apache.pekko scoped util class to Tapir should allow a workaround that can create Content-Length/Content-Type instances.
wdyt? @jrudolph @mdedetrich
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on issue #304: headers.scala case classes have package private constructors - Scala 3 enforces this
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #304:
URL: https://github.com/apache/incubator-pekko-http/issues/304#issuecomment-1682062727
Looks like the Tapir team have worked around this issue so that means we don't need to make an immediate change - but it might still be worth considering whether to make the constructors public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on issue #304: headers.scala case classes have package private constructors - Scala 3 enforces this
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on issue #304:
URL: https://github.com/apache/incubator-pekko-http/issues/304#issuecomment-1700990574
We shouldn't just make something public that was made private intentionally (i.e. probably because we want to uphold some invariants). That said, if there's a need for a public API, we can look into what's needed and add that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org