You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/05 11:18:54 UTC

[GitHub] [flink] aljoscha opened a new pull request #13943: [FLINK-20001] Don't use setAllVerticesInSameSlotSharingGroupByDefault in StreamGraphGenerator

aljoscha opened a new pull request #13943:
URL: https://github.com/apache/flink/pull/13943


   I think the default of having all vertices in the same slot sharing
   group should be good for both BATCH and STREAMING right now. We can
   reconsider actually setting this flag in the future.
   
   Background information: this is a special setting that was introduced
   for the Table API Blink runner/planner, which does special things with
   slot sharing (or lack thereof) and is more aware of memory requirements
   and such. For general DataStream/DataSet programs changing the setting
   doesn't make sense.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? no
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13943: [FLINK-20001] Don't use setAllVerticesInSameSlotSharingGroupByDefault in StreamGraphGenerator

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13943:
URL: https://github.com/apache/flink/pull/13943#issuecomment-722316009


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit a7c72d45341730a5c9e80df8b7d7894a97ea8260 (Thu Nov 05 11:21:50 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha closed pull request #13943: [FLINK-20001] Don't use setAllVerticesInSameSlotSharingGroupByDefault in StreamGraphGenerator

Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #13943:
URL: https://github.com/apache/flink/pull/13943


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha commented on pull request #13943: [FLINK-20001] Don't use setAllVerticesInSameSlotSharingGroupByDefault in StreamGraphGenerator

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13943:
URL: https://github.com/apache/flink/pull/13943#issuecomment-722991796


   Merged!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha closed pull request #13943: [FLINK-20001] Don't use setAllVerticesInSameSlotSharingGroupByDefault in StreamGraphGenerator

Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #13943:
URL: https://github.com/apache/flink/pull/13943


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13943: [FLINK-20001] Don't use setAllVerticesInSameSlotSharingGroupByDefault in StreamGraphGenerator

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13943:
URL: https://github.com/apache/flink/pull/13943#issuecomment-722359596


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a7c72d45341730a5c9e80df8b7d7894a97ea8260",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a7c72d45341730a5c9e80df8b7d7894a97ea8260",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a7c72d45341730a5c9e80df8b7d7894a97ea8260 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13943: [FLINK-20001] Don't use setAllVerticesInSameSlotSharingGroupByDefault in StreamGraphGenerator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13943:
URL: https://github.com/apache/flink/pull/13943#issuecomment-722359596


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a7c72d45341730a5c9e80df8b7d7894a97ea8260",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9088",
       "triggerID" : "a7c72d45341730a5c9e80df8b7d7894a97ea8260",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b47a0c860c156e076c34457071afb2d02415d2d4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9111",
       "triggerID" : "b47a0c860c156e076c34457071afb2d02415d2d4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a7c72d45341730a5c9e80df8b7d7894a97ea8260 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9088) 
   * b47a0c860c156e076c34457071afb2d02415d2d4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9111) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13943: [FLINK-20001] Don't use setAllVerticesInSameSlotSharingGroupByDefault in StreamGraphGenerator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13943:
URL: https://github.com/apache/flink/pull/13943#issuecomment-722359596


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a7c72d45341730a5c9e80df8b7d7894a97ea8260",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9088",
       "triggerID" : "a7c72d45341730a5c9e80df8b7d7894a97ea8260",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b47a0c860c156e076c34457071afb2d02415d2d4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b47a0c860c156e076c34457071afb2d02415d2d4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a7c72d45341730a5c9e80df8b7d7894a97ea8260 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9088) 
   * b47a0c860c156e076c34457071afb2d02415d2d4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] kl0u commented on pull request #13943: [FLINK-20001] Don't use setAllVerticesInSameSlotSharingGroupByDefault in StreamGraphGenerator

Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #13943:
URL: https://github.com/apache/flink/pull/13943#issuecomment-722386473


   Definitely tests in the `StreamGraphGeneratorExecutionModeDetectionTest` (and maybe elsewhere) will fail.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13943: [FLINK-20001] Don't use setAllVerticesInSameSlotSharingGroupByDefault in StreamGraphGenerator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13943:
URL: https://github.com/apache/flink/pull/13943#issuecomment-722359596


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a7c72d45341730a5c9e80df8b7d7894a97ea8260",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9088",
       "triggerID" : "a7c72d45341730a5c9e80df8b7d7894a97ea8260",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b47a0c860c156e076c34457071afb2d02415d2d4",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9111",
       "triggerID" : "b47a0c860c156e076c34457071afb2d02415d2d4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b47a0c860c156e076c34457071afb2d02415d2d4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9111) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] kl0u commented on pull request #13943: [FLINK-20001] Don't use setAllVerticesInSameSlotSharingGroupByDefault in StreamGraphGenerator

Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #13943:
URL: https://github.com/apache/flink/pull/13943#issuecomment-722390623


   There are definitely tests in the `StreamGraphGeneratorExecutionModeDetectionTest` that will fail.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] kl0u removed a comment on pull request #13943: [FLINK-20001] Don't use setAllVerticesInSameSlotSharingGroupByDefault in StreamGraphGenerator

Posted by GitBox <gi...@apache.org>.
kl0u removed a comment on pull request #13943:
URL: https://github.com/apache/flink/pull/13943#issuecomment-722386473


   Definitely tests in the `StreamGraphGeneratorExecutionModeDetectionTest` (and maybe elsewhere) will fail.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13943: [FLINK-20001] Don't use setAllVerticesInSameSlotSharingGroupByDefault in StreamGraphGenerator

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13943:
URL: https://github.com/apache/flink/pull/13943#issuecomment-722359596


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a7c72d45341730a5c9e80df8b7d7894a97ea8260",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9088",
       "triggerID" : "a7c72d45341730a5c9e80df8b7d7894a97ea8260",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a7c72d45341730a5c9e80df8b7d7894a97ea8260 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9088) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org