You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by hvanhovell <gi...@git.apache.org> on 2016/12/13 15:05:10 UTC

[GitHub] spark pull request #16255: [SPARK-18609][SQL]Fix when CTE with Join between ...

Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16255#discussion_r92186722
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ---
    @@ -416,8 +418,8 @@ object ColumnPruning extends Rule[LogicalPlan] {
         case w: Window if w.windowExpressions.isEmpty => w.child
     
         // Eliminate no-op Projects
    -    case p @ Project(_, child) if sameOutput(child.output, p.output) => child
    -
    +    case p @ Project(_, child) if sameOutput(child.output, p.output) =>
    +      if (child.isInstanceOf[CatalogRelation]) p else child
    --- End diff --
    
    Why is a CatalogRelation different?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org