You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/03 02:58:33 UTC
[GitHub] [airflow] sunkickr opened a new pull request #15632: Add link to Oracle Connection Docs
sunkickr opened a new pull request #15632:
URL: https://github.com/apache/airflow/pull/15632
This PR adds a link to the Oracle Connection docs to the docstrings of modules that use the oracle conn id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on pull request #15632: Add link to Oracle Connection Docs
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on pull request #15632:
URL: https://github.com/apache/airflow/pull/15632#issuecomment-831668478
@sunkickr This looks good. Can you include the oracle connection id type (I'm guessing either string or int) to those docblocks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins merged pull request #15632: Add link to Oracle Connection Docs
Posted by GitBox <gi...@apache.org>.
jhtimmins merged pull request #15632:
URL: https://github.com/apache/airflow/pull/15632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sunkickr commented on pull request #15632: Add link to Oracle Connection Docs
Posted by GitBox <gi...@apache.org>.
sunkickr commented on pull request #15632:
URL: https://github.com/apache/airflow/pull/15632#issuecomment-832000048
@jhtimmins I think the type is already specified under the param for each conn id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sunkickr commented on pull request #15632: Add link to Oracle Connection Docs
Posted by GitBox <gi...@apache.org>.
sunkickr commented on pull request #15632:
URL: https://github.com/apache/airflow/pull/15632#issuecomment-833751431
@kaxil could you review? I think everything should good with this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15632: Add link to Oracle Connection Docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15632:
URL: https://github.com/apache/airflow/pull/15632#issuecomment-833766274
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org