You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alex Blewitt (JIRA)" <ji...@apache.org> on 2006/12/06 00:29:21 UTC

[jira] Created: (HARMONY-2479) [classlib][pack200] Move pack200 code to its own module

[classlib][pack200] Move pack200 code to its own module
-------------------------------------------------------

                 Key: HARMONY-2479
                 URL: http://issues.apache.org/jira/browse/HARMONY-2479
             Project: Harmony
          Issue Type: Improvement
          Components: Classlib
            Reporter: Alex Blewitt
            Priority: Minor


The pack200 code currently lives in the archive module, which will ultimately result in a tighter coupling of the internal pack200 code and the external java.util.jar code. Furthermore, whilst the java.util.jar is using generics internally, the pack200 stuff needs to avoid the use of generics and putting it into a different module will allow the compiler and project settings to be appropriately amended.

We should create another module (e.g. archive-pack200) and then move the o.a.h.a.internal.pack200 and test code into that new module instead, perhaps with a package name change, and then set up a template build.xml and Manifest.MF. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2479) [classlib][pack200] Move pack200 code to its own module

Posted by "Alex Blewitt (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-2479?page=comments#action_12460588 ] 
            
Alex Blewitt commented on HARMONY-2479:
---------------------------------------

The Java sources are all under:

src/main/java/org/apache/harmony/archive/internal/pack200
src/test/java/org/apache/harmony/archive/tests/internal/pack200

The resources are under:

src/test/resources/org/apache/harmony/archive/tests/internal/pack200/

I suspect as a different module (modules/pack200?) the packages might need renaming?

There's also an AllTests in the archive module which points to an pack200/AllTests which might need to be fixed.

Do you need any more details for the files, or are the containing directories sufficient?

> [classlib][pack200] Move pack200 code to its own module
> -------------------------------------------------------
>
>                 Key: HARMONY-2479
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2479
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>
> The pack200 code currently lives in the archive module, which will ultimately result in a tighter coupling of the internal pack200 code and the external java.util.jar code. Furthermore, whilst the java.util.jar is using generics internally, the pack200 stuff needs to avoid the use of generics and putting it into a different module will allow the compiler and project settings to be appropriately amended.
> We should create another module (e.g. archive-pack200) and then move the o.a.h.a.internal.pack200 and test code into that new module instead, perhaps with a package name change, and then set up a template build.xml and Manifest.MF. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2479) [classlib][pack200] Move pack200 code to its own module

Posted by "Alex Blewitt (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-2479?page=comments#action_12460716 ] 
            
Alex Blewitt commented on HARMONY-2479:
---------------------------------------

No, there's no native code. I'm easy as to whether the AllTests is kept; after all, it's just extra maintenance to have around. But when you move the pack200 tests out, there's an archive AllTests that currently refers to it that will need to be edited, that's all.

> [classlib][pack200] Move pack200 code to its own module
> -------------------------------------------------------
>
>                 Key: HARMONY-2479
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2479
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>
> The pack200 code currently lives in the archive module, which will ultimately result in a tighter coupling of the internal pack200 code and the external java.util.jar code. Furthermore, whilst the java.util.jar is using generics internally, the pack200 stuff needs to avoid the use of generics and putting it into a different module will allow the compiler and project settings to be appropriately amended.
> We should create another module (e.g. archive-pack200) and then move the o.a.h.a.internal.pack200 and test code into that new module instead, perhaps with a package name change, and then set up a template build.xml and Manifest.MF. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2479) [classlib][pack200] Move pack200 code to its own module

Posted by "Alex Blewitt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465445 ] 

Alex Blewitt commented on HARMONY-2479:
---------------------------------------

I guess this bug can be closed -- the code is in there now. I've put in a patch (HARMONY-2957) for a few other things, but there doesn't seem to be much motion on that one.

> [classlib][pack200] Move pack200 code to its own module
> -------------------------------------------------------
>
>                 Key: HARMONY-2479
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2479
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>
> The pack200 code currently lives in the archive module, which will ultimately result in a tighter coupling of the internal pack200 code and the external java.util.jar code. Furthermore, whilst the java.util.jar is using generics internally, the pack200 stuff needs to avoid the use of generics and putting it into a different module will allow the compiler and project settings to be appropriately amended.
> We should create another module (e.g. archive-pack200) and then move the o.a.h.a.internal.pack200 and test code into that new module instead, perhaps with a package name change, and then set up a template build.xml and Manifest.MF. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2479) [classlib][pack200] Move pack200 code to its own module

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462612 ] 

Alexei Zakharov commented on HARMONY-2479:
------------------------------------------

Alex, sorry for the delay. We have quite a long New Year holidays here in Russia. I've almost finished the transfer and suppose we will have the new module in a couple of days.

> [classlib][pack200] Move pack200 code to its own module
> -------------------------------------------------------
>
>                 Key: HARMONY-2479
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2479
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>
> The pack200 code currently lives in the archive module, which will ultimately result in a tighter coupling of the internal pack200 code and the external java.util.jar code. Furthermore, whilst the java.util.jar is using generics internally, the pack200 stuff needs to avoid the use of generics and putting it into a different module will allow the compiler and project settings to be appropriately amended.
> We should create another module (e.g. archive-pack200) and then move the o.a.h.a.internal.pack200 and test code into that new module instead, perhaps with a package name change, and then set up a template build.xml and Manifest.MF. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2479) [classlib][pack200] Move pack200 code to its own module

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-2479?page=comments#action_12460670 ] 
            
Alexei Zakharov commented on HARMONY-2479:
------------------------------------------

So there is no native, only java. Am I right? I suppose we should rename the packages to org.apache.harmony.pack200 and org.apache.harmony.pack200.tests . I'm not  sure we need AllTests at all since it is not really used by the current build system.

> [classlib][pack200] Move pack200 code to its own module
> -------------------------------------------------------
>
>                 Key: HARMONY-2479
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2479
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>
> The pack200 code currently lives in the archive module, which will ultimately result in a tighter coupling of the internal pack200 code and the external java.util.jar code. Furthermore, whilst the java.util.jar is using generics internally, the pack200 stuff needs to avoid the use of generics and putting it into a different module will allow the compiler and project settings to be appropriately amended.
> We should create another module (e.g. archive-pack200) and then move the o.a.h.a.internal.pack200 and test code into that new module instead, perhaps with a package name change, and then set up a template build.xml and Manifest.MF. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2479) [classlib][pack200] Move pack200 code to its own module

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-2479?page=comments#action_12460220 ] 
            
Alexei Zakharov commented on HARMONY-2479:
------------------------------------------

Alex, please can you give the exact list of files (java sources, tests, resources, etc.) that you await to be moved? Thanks.

> [classlib][pack200] Move pack200 code to its own module
> -------------------------------------------------------
>
>                 Key: HARMONY-2479
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2479
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>
> The pack200 code currently lives in the archive module, which will ultimately result in a tighter coupling of the internal pack200 code and the external java.util.jar code. Furthermore, whilst the java.util.jar is using generics internally, the pack200 stuff needs to avoid the use of generics and putting it into a different module will allow the compiler and project settings to be appropriately amended.
> We should create another module (e.g. archive-pack200) and then move the o.a.h.a.internal.pack200 and test code into that new module instead, perhaps with a package name change, and then set up a template build.xml and Manifest.MF. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2479) [classlib][pack200] Move pack200 code to its own module

Posted by "Alex Blewitt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462170 ] 

Alex Blewitt commented on HARMONY-2479:
---------------------------------------

Alexei, is there anything else you need from me for this? Can I do anything to help?

> [classlib][pack200] Move pack200 code to its own module
> -------------------------------------------------------
>
>                 Key: HARMONY-2479
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2479
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>
> The pack200 code currently lives in the archive module, which will ultimately result in a tighter coupling of the internal pack200 code and the external java.util.jar code. Furthermore, whilst the java.util.jar is using generics internally, the pack200 stuff needs to avoid the use of generics and putting it into a different module will allow the compiler and project settings to be appropriately amended.
> We should create another module (e.g. archive-pack200) and then move the o.a.h.a.internal.pack200 and test code into that new module instead, perhaps with a package name change, and then set up a template build.xml and Manifest.MF. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (HARMONY-2479) [classlib][pack200] Move pack200 code to its own module

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Zakharov resolved HARMONY-2479.
--------------------------------------

    Resolution: Fixed

Ok, let's close it. The good bug is a closed bug. We can reopen it and close as won't fix if community votes for moving pack200 back the archive module.

> [classlib][pack200] Move pack200 code to its own module
> -------------------------------------------------------
>
>                 Key: HARMONY-2479
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2479
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>
> The pack200 code currently lives in the archive module, which will ultimately result in a tighter coupling of the internal pack200 code and the external java.util.jar code. Furthermore, whilst the java.util.jar is using generics internally, the pack200 stuff needs to avoid the use of generics and putting it into a different module will allow the compiler and project settings to be appropriately amended.
> We should create another module (e.g. archive-pack200) and then move the o.a.h.a.internal.pack200 and test code into that new module instead, perhaps with a package name change, and then set up a template build.xml and Manifest.MF. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2479) [classlib][pack200] Move pack200 code to its own module

Posted by "Alex Blewitt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462631 ] 

Alex Blewitt commented on HARMONY-2479:
---------------------------------------

Happy new year :-) No problems, I'm happy waiting. I was just concerned that maybe I'd not given you enough information/help. I'll look forward to it :-)

> [classlib][pack200] Move pack200 code to its own module
> -------------------------------------------------------
>
>                 Key: HARMONY-2479
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2479
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>
> The pack200 code currently lives in the archive module, which will ultimately result in a tighter coupling of the internal pack200 code and the external java.util.jar code. Furthermore, whilst the java.util.jar is using generics internally, the pack200 stuff needs to avoid the use of generics and putting it into a different module will allow the compiler and project settings to be appropriately amended.
> We should create another module (e.g. archive-pack200) and then move the o.a.h.a.internal.pack200 and test code into that new module instead, perhaps with a package name change, and then set up a template build.xml and Manifest.MF. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (HARMONY-2479) [classlib][pack200] Move pack200 code to its own module

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2479?page=all ]

Alexei Zakharov reassigned HARMONY-2479:
----------------------------------------

    Assignee: Alexei Zakharov

> [classlib][pack200] Move pack200 code to its own module
> -------------------------------------------------------
>
>                 Key: HARMONY-2479
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2479
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>
> The pack200 code currently lives in the archive module, which will ultimately result in a tighter coupling of the internal pack200 code and the external java.util.jar code. Furthermore, whilst the java.util.jar is using generics internally, the pack200 stuff needs to avoid the use of generics and putting it into a different module will allow the compiler and project settings to be appropriately amended.
> We should create another module (e.g. archive-pack200) and then move the o.a.h.a.internal.pack200 and test code into that new module instead, perhaps with a package name change, and then set up a template build.xml and Manifest.MF. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (HARMONY-2479) [classlib][pack200] Move pack200 code to its own module

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Zakharov closed HARMONY-2479.
------------------------------------


> [classlib][pack200] Move pack200 code to its own module
> -------------------------------------------------------
>
>                 Key: HARMONY-2479
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2479
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>         Assigned To: Alexei Zakharov
>            Priority: Minor
>
> The pack200 code currently lives in the archive module, which will ultimately result in a tighter coupling of the internal pack200 code and the external java.util.jar code. Furthermore, whilst the java.util.jar is using generics internally, the pack200 stuff needs to avoid the use of generics and putting it into a different module will allow the compiler and project settings to be appropriately amended.
> We should create another module (e.g. archive-pack200) and then move the o.a.h.a.internal.pack200 and test code into that new module instead, perhaps with a package name change, and then set up a template build.xml and Manifest.MF. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira