You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:07:21 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #3946: Rename MODULE_TEXT to TEXT_HEAP.
Ouss4 opened a new pull request #3946:
URL: https://github.com/apache/incubator-nuttx/pull/3946
## Summary
Rename MODULE_TEXT to TEXT_HEAP as the latter is more generic. Also renames other variations like modtext, etc.
## Impact
The usage of CONFIG_ARCH_MODULE_TEXT. It has to be changed to CONFIG_ARCH_TEXT_HEAP.
## Testing
esp32-devkitc:elf esp32-devkitc:sotest esp32-devkitc:module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #3946: Rename MODULE_TEXT to TEXT_HEAP.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #3946:
URL: https://github.com/apache/incubator-nuttx/pull/3946#discussion_r654260062
##########
File path: arch/xtensa/src/esp32s2/Make.defs
##########
@@ -79,8 +79,3 @@ ifeq ($(CONFIG_ESP32S2_UART),y)
CMN_CSRCS += esp32s2_serial.c
endif
-ifeq ($(CONFIG_ARCH_USE_MODULE_TEXT),y)
-CHIP_CSRCS += esp32s2_modtext.c
-CMN_ASRCS += xtensa_loadstore.S
-endif
Review comment:
yeah... I'm about to delete it.. I just didn't want to spend time on it. This was a copy past from the ESP32 port that shouldn't even be here.
ESP32-S2 memory model is similar to ESP32-C3 not ESP32. We don't have a separate region accessed only by I-Bus. So its (now non-existent) text allocator would just allocate from the main heap and adjust the buffer to be accessed from I-Bus. I didn't do this for ESP32-S2 because the port is new. I want to wait until we have more into it.
##########
File path: arch/xtensa/src/esp32s2/Make.defs
##########
@@ -79,8 +79,3 @@ ifeq ($(CONFIG_ESP32S2_UART),y)
CMN_CSRCS += esp32s2_serial.c
endif
-ifeq ($(CONFIG_ARCH_USE_MODULE_TEXT),y)
-CHIP_CSRCS += esp32s2_modtext.c
-CMN_ASRCS += xtensa_loadstore.S
-endif
Review comment:
> I'm about to delete it..
This was in reference to the `esp32s2_user.c` part.
##########
File path: arch/xtensa/src/esp32s2/Make.defs
##########
@@ -79,8 +79,3 @@ ifeq ($(CONFIG_ESP32S2_UART),y)
CMN_CSRCS += esp32s2_serial.c
endif
-ifeq ($(CONFIG_ARCH_USE_MODULE_TEXT),y)
-CHIP_CSRCS += esp32s2_modtext.c
-CMN_ASRCS += xtensa_loadstore.S
-endif
Review comment:
yeah, I'm about to delete it.. I just didn't want to spend time on it. This was a copy past from the ESP32 port that shouldn't even be here.
ESP32-S2 memory model is similar to ESP32-C3 not ESP32. We don't have a separate region accessed only by I-Bus. So its (now non-existent) text allocator would just allocate from the main heap and adjust the buffer to be accessed from I-Bus. I didn't do this for ESP32-S2 because the port is new. I want to wait until we have more into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3946: Rename MODULE_TEXT to TEXT_HEAP.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3946:
URL: https://github.com/apache/incubator-nuttx/pull/3946#issuecomment-863776854
@Ouss4 the new name looks good, please rebase your change, #3945 just merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #3946: Rename MODULE_TEXT to TEXT_HEAP.
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #3946:
URL: https://github.com/apache/incubator-nuttx/pull/3946#issuecomment-863762303
Error: chip/esp32c3_modtext.c:50:6: error: function declaration isn't a prototype [-Werror=strict-prototypes]
void up_module_text_init()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3946: Rename MODULE_TEXT to TEXT_HEAP.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3946:
URL: https://github.com/apache/incubator-nuttx/pull/3946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3946: Rename MODULE_TEXT to TEXT_HEAP.
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #3946:
URL: https://github.com/apache/incubator-nuttx/pull/3946#issuecomment-863659322
@Ouss4
LGTM but it seems that there were build errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #3946: Rename MODULE_TEXT to TEXT_HEAP.
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #3946:
URL: https://github.com/apache/incubator-nuttx/pull/3946#issuecomment-863633831
i have no problem with the new name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #3946: Rename MODULE_TEXT to TEXT_HEAP.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #3946:
URL: https://github.com/apache/incubator-nuttx/pull/3946#issuecomment-863631625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #3946: Rename MODULE_TEXT to TEXT_HEAP.
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #3946:
URL: https://github.com/apache/incubator-nuttx/pull/3946#discussion_r654254788
##########
File path: arch/xtensa/src/esp32s2/Make.defs
##########
@@ -79,8 +79,3 @@ ifeq ($(CONFIG_ESP32S2_UART),y)
CMN_CSRCS += esp32s2_serial.c
endif
-ifeq ($(CONFIG_ARCH_USE_MODULE_TEXT),y)
-CHIP_CSRCS += esp32s2_modtext.c
-CMN_ASRCS += xtensa_loadstore.S
-endif
Review comment:
esp32s2 part is not obvious to me.
can you explain a bit?
##########
File path: arch/xtensa/src/esp32s2/Make.defs
##########
@@ -79,8 +79,3 @@ ifeq ($(CONFIG_ESP32S2_UART),y)
CMN_CSRCS += esp32s2_serial.c
endif
-ifeq ($(CONFIG_ARCH_USE_MODULE_TEXT),y)
-CHIP_CSRCS += esp32s2_modtext.c
-CMN_ASRCS += xtensa_loadstore.S
-endif
Review comment:
ok. i got it. thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org