[GitHub] [incubator-gobblin] jack-moseley commented on a change in pull request #2640: [GOBBLIN-775] Add job level retries for gobblin service

[GitBox <gi...@apache.org>]

jack-moseley commented on a change in pull request #2640: [GOBBLIN-775] Add job level retries for gobblin service
URL: https://github.com/apache/incubator-gobblin/pull/2640#discussion_r287153336
 
 

 ##########
 File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
 ##########
 @@ -457,6 +462,15 @@ private void submitJob(DagNode<JobExecutionPlan> dagNode) {
       JobSpec jobSpec = DagManagerUtils.getJobSpec(dagNode);
       Map<String, String> jobMetadata = TimingEventUtils.getJobMetadata(Maps.newHashMap(), jobExecutionPlan);
 
+      // Increment submission attempt
 
 Review comment:
   I don't think the incrementing logic should be in there because it could be called at a time other than job submission. But I moved the logic for updating the map to there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services