[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1226: MINIFICPP-1673: ProcessSession::write/ProcessSession::append should o…

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #1226:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1226#discussion_r767623866



##########
File path: libminifi/src/core/ProcessSession.cpp
##########
@@ -212,6 +212,10 @@ void ProcessSession::transfer(const std::shared_ptr<core::FlowFile> &flow, Relat
 }
 
 void ProcessSession::write(const std::shared_ptr<core::FlowFile> &flow, OutputStreamCallback *callback) {
+  gsl_Expects(_updatedFlowFiles.contains(flow->getUUID())
+              || _addedFlowFiles.contains(flow->getUUID())
+              || std::any_of(_clonedFlowFiles.begin(), _clonedFlowFiles.end(), [&flow](const auto& cloned_flow_file) { return flow == cloned_flow_file; }));
+

Review comment:
       This check looks like it's on the more expensive side. Consider changing it to [`gsl_ExpectsAudit`](https://github.com/gsl-lite/gsl-lite#contract-checking-configuration-macros) to remove the check from non-CI builds that don't define `gsl_CONFIG_CONTRACT_CHECKING_AUDIT`. (same in append)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org