You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/31 15:39:40 UTC
[GitHub] [spark] cloud-fan opened a new pull request #29321: [SPARK-32083][SQL][3.0] AQE coalesce should at least return one partition
cloud-fan opened a new pull request #29321:
URL: https://github.com/apache/spark/pull/29321
This is a partial backport of https://github.com/apache/spark/pull/29307
Most of the changes are not needed because https://github.com/cloud-fan/spark/commit/69f9ee18b66991f8d6989fa20f93cd7343be28a9#diff-3ad09c07c2a3bc71e3c90d3307bb9611 is in master only.
This PR only backports the safeguard in `ShuffleExchangeExec.canChangeNumPartitions`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29321: [SPARK-32083][SQL][3.0] AQE coalesce should at least return one partition
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667343593
**[Test build #126892 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126892/testReport)** for PR 29321 at commit [`4a0692a`](https://github.com/apache/spark/commit/4a0692a7e67bdb96623a69b2a5bda0b12d2271f6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29321: [SPARK-32083][SQL][3.0] AQE should not coalesce partitions for SinglePartition
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667995877
**[Test build #126967 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126967/testReport)** for PR 29321 at commit [`6a06fba`](https://github.com/apache/spark/commit/6a06fba70cce84cf23b6d85951fb99d25c7adcc7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29321: [SPARK-32083][SQL][3.0] AQE coalesce should at least return one partition
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667344629
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29321: [SPARK-32083][SQL][3.0] AQE should not coalesce partitions for SinglePartition
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667845753
**[Test build #126948 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126948/testReport)** for PR 29321 at commit [`6a06fba`](https://github.com/apache/spark/commit/6a06fba70cce84cf23b6d85951fb99d25c7adcc7).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29321: [SPARK-32083][SQL][3.0] AQE should not coalesce partitions for SinglePartition
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667846039
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29321: [SPARK-32083][SQL][3.0] AQE coalesce should at least return one partition
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667789287
**[Test build #126948 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126948/testReport)** for PR 29321 at commit [`6a06fba`](https://github.com/apache/spark/commit/6a06fba70cce84cf23b6d85951fb99d25c7adcc7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29321: [SPARK-32083][SQL][3.0] AQE coalesce should at least return one partition
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667189708
**[Test build #126892 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126892/testReport)** for PR 29321 at commit [`4a0692a`](https://github.com/apache/spark/commit/4a0692a7e67bdb96623a69b2a5bda0b12d2271f6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29321: [SPARK-32083][SQL][3.0] AQE coalesce should at least return one partition
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667789608
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29321: [SPARK-32083][SQL][3.0] AQE should not coalesce partitions for SinglePartition
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-668007201
merged to 3.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29321: [SPARK-32083][SQL][3.0] AQE should not coalesce partitions for SinglePartition
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667866377
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29321: [SPARK-32083][SQL][3.0] AQE coalesce should at least return one partition
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667344629
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29321: [SPARK-32083][SQL][3.0] AQE coalesce should at least return one partition
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667240249
Could you resolve the conflict, @cloud-fan ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29321: [SPARK-32083][SQL][3.0] AQE should not coalesce partitions for SinglePartition
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667789287
**[Test build #126948 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126948/testReport)** for PR 29321 at commit [`6a06fba`](https://github.com/apache/spark/commit/6a06fba70cce84cf23b6d85951fb99d25c7adcc7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29321: [SPARK-32083][SQL][3.0] AQE coalesce should at least return one partition
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667187915
cc @manuzhang @viirya
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29321: [SPARK-32083][SQL][3.0] AQE should not coalesce partitions for SinglePartition
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667846039
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29321: [SPARK-32083][SQL][3.0] AQE should not coalesce partitions for SinglePartition
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667876262
**[Test build #126967 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126967/testReport)** for PR 29321 at commit [`6a06fba`](https://github.com/apache/spark/commit/6a06fba70cce84cf23b6d85951fb99d25c7adcc7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29321: [SPARK-32083][SQL][3.0] AQE should not coalesce partitions for SinglePartition
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667846050
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126948/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29321: [SPARK-32083][SQL][3.0] AQE should not coalesce partitions for SinglePartition
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667869464
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29321: [SPARK-32083][SQL][3.0] AQE coalesce should at least return one partition
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667189708
**[Test build #126892 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126892/testReport)** for PR 29321 at commit [`4a0692a`](https://github.com/apache/spark/commit/4a0692a7e67bdb96623a69b2a5bda0b12d2271f6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29321: [SPARK-32083][SQL][3.0] AQE should not coalesce partitions for SinglePartition
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667996852
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] manuzhang commented on pull request #29321: [SPARK-32083][SQL][3.0] AQE coalesce should at least return one partition
Posted by GitBox <gi...@apache.org>.
manuzhang commented on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667814511
@cloud-fan
The title seems not to be related to the partial backport.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29321: [SPARK-32083][SQL][3.0] AQE coalesce should at least return one partition
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667789608
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29321: [SPARK-32083][SQL][3.0] AQE should not coalesce partitions for SinglePartition
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667876262
**[Test build #126967 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126967/testReport)** for PR 29321 at commit [`6a06fba`](https://github.com/apache/spark/commit/6a06fba70cce84cf23b6d85951fb99d25c7adcc7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29321: [SPARK-32083][SQL][3.0] AQE coalesce should at least return one partition
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667190476
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #29321: [SPARK-32083][SQL][3.0] AQE should not coalesce partitions for SinglePartition
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #29321:
URL: https://github.com/apache/spark/pull/29321
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29321: [SPARK-32083][SQL][3.0] AQE should not coalesce partitions for SinglePartition
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667996852
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29321: [SPARK-32083][SQL][3.0] AQE coalesce should at least return one partition
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667190476
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29321: [SPARK-32083][SQL][3.0] AQE should not coalesce partitions for SinglePartition
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29321:
URL: https://github.com/apache/spark/pull/29321#issuecomment-667869464
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org