You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/25 01:03:57 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #4567: Add
missing `@Repeatable` to `@Tag` annotation
kezhenxu94 opened a new pull request #4567: Add missing `@Repeatable` to `@Tag` annotation
URL: https://github.com/apache/skywalking/pull/4567
Happen to find that the `@Repeatable` annotation is missing in `@Tag` in the plugin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4567: Add missing
`@Repeatable` to `@Tag` annotation
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4567: Add missing `@Repeatable` to `@Tag` annotation
URL: https://github.com/apache/skywalking/pull/4567#issuecomment-603596960
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4567?src=pr&el=h1) Report
> Merging [#4567](https://codecov.io/gh/apache/skywalking/pull/4567?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e7f66c911eaf18a14793e5edf09788cb5f391f29&el=desc) will **increase** coverage by `0.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4567 +/- ##
==========================================
+ Coverage 25.57% 25.87% +0.29%
==========================================
Files 1246 1246
Lines 28975 28975
Branches 3974 3974
==========================================
+ Hits 7410 7496 +86
+ Misses 20873 20786 -87
- Partials 692 693 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4567?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/4567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `75.00% <0.00%> (-3.58%)` | :arrow_down: |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/4567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `62.28% <0.00%> (+0.84%)` | :arrow_up: |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `27.95% <0.00%> (+2.15%)` | :arrow_up: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `60.00% <0.00%> (+3.33%)` | :arrow_up: |
| [...m/agent/core/remote/TraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RyYWNlU2VnbWVudFNlcnZpY2VDbGllbnQuamF2YQ==) | `80.82% <0.00%> (+5.47%)` | :arrow_up: |
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `30.61% <0.00%> (+8.16%)` | :arrow_up: |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `22.22% <0.00%> (+22.22%)` | :arrow_up: |
| [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/4567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `66.66% <0.00%> (+29.48%)` | :arrow_up: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `44.44% <0.00%> (+44.44%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/skywalking/pull/4567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4567?src=pr&el=footer). Last update [e7f66c9...b895375](https://codecov.io/gh/apache/skywalking/pull/4567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4567: Add missing
`@Repeatable` to `@Tag` annotation
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4567: Add missing `@Repeatable` to `@Tag` annotation
URL: https://github.com/apache/skywalking/pull/4567
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services