[GitHub] [iceberg] rdsr commented on a change in pull request #1267: Single jar for input formats

[GitBox <gi...@apache.org>]

rdsr commented on a change in pull request #1267:
URL: https://github.com/apache/iceberg/pull/1267#discussion_r462551062



##########
File path: build.gradle
##########
@@ -404,6 +408,29 @@ project(':iceberg-mr') {
       exclude group: 'org.apache.calcite.avatica'
     }
   }
+
+  shadowJar {
+    configurations = [project.configurations.compile]
+
+    zip64 true
+
+    // include the LICENSE and NOTICE files for the shaded Jar
+    from(projectDir) {
+      include 'LICENSE'
+      include 'NOTICE'
+    }
+
+    dependencies {
+      include(dependency('com.github.ben-manes.caffeine:caffeine:'))

Review comment:
       why not add dependencies using the `compile` configuration. ? Adding it this way, I think only adds that specific dependency. Also I'm not sure just using a group id is a good idea here as it may include unnecessary jars.
   
   Maybe we can do something similar to what other runtime modules are doing

##########
File path: build.gradle
##########
@@ -404,6 +408,29 @@ project(':iceberg-mr') {
       exclude group: 'org.apache.calcite.avatica'
     }
   }
+
+  shadowJar {
+    configurations = [project.configurations.compile]
+
+    zip64 true
+
+    // include the LICENSE and NOTICE files for the shaded Jar
+    from(projectDir) {
+      include 'LICENSE'
+      include 'NOTICE'
+    }
+
+    dependencies {
+      include(dependency('com.github.ben-manes.caffeine:caffeine:'))

Review comment:
       why not add dependencies using the `compile` configuration. ? Adding it this way, I think only adds that specific dependency and not their transitive artifacts. Also I'm not sure just using a group id is a good idea here as it may include unnecessary jars.
   
   Maybe we can do something similar to what other runtime modules are doing




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org