[jira] [Commented] (BOOKKEEPER-937) Upgrade protobuf to 2.6

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15359652#comment-15359652 ] 

ASF GitHub Bot commented on BOOKKEEPER-937:
-------------------------------------------

Github user dlg99 commented on the issue:

    https://github.com/apache/bookkeeper/pull/51
  
    I looked at the jenkins failure for the pull request and it does not look related to the changes. 
    It looks like BOOKKEEPER-876 
    I cannot repro it locally.


> Upgrade protobuf to 2.6
> -----------------------
>
>                 Key: BOOKKEEPER-937
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-937
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: bookkeeper-server
>    Affects Versions: 4.5.0
>            Reporter: Andrey Yegorov
>            Priority: Minor
>              Labels: protobuf
>
> I had to update protobuf definition for some internal experiments and found that working with protobuf 2.4 is rather inconvenient. It cannot be installed with brew on mac and building it on mac always result is build errors hence leaves an option of switching to linux to run protoc.
> I decided to upgrade to 2.6 instead. It is compatible with 2.4 on wire and shaded so should not create any problems. All tests passed.
> Please ignore changes in java files in attached patch during review; these are auto-generated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)