You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/09/25 18:19:34 UTC
[Impala-ASF-CR] IMPALA-12464: Add opens for java.util.regex
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20510
Change subject: IMPALA-12464: Add opens for java.util.regex
......................................................................
IMPALA-12464: Add opens for java.util.regex
Adds --add-opens for java.util.regex with jamm for JDK 17. Java 15 added
hidden classes to define lambdas, and Jamm is unable to access fields of
hidden classes unless add-opens is added for the class.
Change-Id: I9909985fa15ed1b0bc92b04d6ab2645244a0bee3
---
M be/src/common/init.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/20510/1
--
To view, visit http://gerrit.cloudera.org:8080/20510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9909985fa15ed1b0bc92b04d6ab2645244a0bee3
Gerrit-Change-Number: 20510
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12464: Add opens for java.util.regex
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20510 )
Change subject: IMPALA-12464: Add opens for java.util.regex
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9909985fa15ed1b0bc92b04d6ab2645244a0bee3
Gerrit-Change-Number: 20510
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Sep 2023 18:05:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12464: Add opens for java.util.regex
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has removed a vote on this change.
Change subject: IMPALA-12464: Add opens for java.util.regex
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/20510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I9909985fa15ed1b0bc92b04d6ab2645244a0bee3
Gerrit-Change-Number: 20510
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12464: Add opens for java.util.regex
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20510 )
Change subject: IMPALA-12464: Add opens for java.util.regex
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9780/
--
To view, visit http://gerrit.cloudera.org:8080/20510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9909985fa15ed1b0bc92b04d6ab2645244a0bee3
Gerrit-Change-Number: 20510
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Sep 2023 22:22:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12464: Add opens for java.util.regex
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20510 )
Change subject: IMPALA-12464: Add opens for java.util.regex
......................................................................
Patch Set 2: Verified+1
Only test failure was IMPALA-1995.
--
To view, visit http://gerrit.cloudera.org:8080/20510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9909985fa15ed1b0bc92b04d6ab2645244a0bee3
Gerrit-Change-Number: 20510
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Oct 2023 17:18:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12464: Add opens for java.util.regex
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20510 )
Change subject: IMPALA-12464: Add opens for java.util.regex
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9780/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9909985fa15ed1b0bc92b04d6ab2645244a0bee3
Gerrit-Change-Number: 20510
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Sep 2023 18:05:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12464: Add opens for java.util.regex
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20510 )
Change subject: IMPALA-12464: Add opens for java.util.regex
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/14076/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9909985fa15ed1b0bc92b04d6ab2645244a0bee3
Gerrit-Change-Number: 20510
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Sep 2023 18:47:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12464: Add opens for java.util.regex
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has removed a vote on this change.
Change subject: IMPALA-12464: Add opens for java.util.regex
......................................................................
Removed -Verified by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/20510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I9909985fa15ed1b0bc92b04d6ab2645244a0bee3
Gerrit-Change-Number: 20510
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12464: Add opens for java.util.regex
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20510 )
Change subject: IMPALA-12464: Add opens for java.util.regex
......................................................................
IMPALA-12464: Add opens for java.util.regex
Adds --add-opens for java.util.regex with jamm for JDK 17. Java 15 added
hidden classes to define lambdas, and Jamm is unable to access fields of
hidden classes unless add-opens is added for the class.
Change-Id: I9909985fa15ed1b0bc92b04d6ab2645244a0bee3
Reviewed-on: http://gerrit.cloudera.org:8080/20510
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M be/src/common/init.cc
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved
Michael Smith: Verified
--
To view, visit http://gerrit.cloudera.org:8080/20510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9909985fa15ed1b0bc92b04d6ab2645244a0bee3
Gerrit-Change-Number: 20510
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12464: Add opens for java.util.regex
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/20510 )
Change subject: IMPALA-12464: Add opens for java.util.regex
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9909985fa15ed1b0bc92b04d6ab2645244a0bee3
Gerrit-Change-Number: 20510
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Sep 2023 15:27:36 +0000
Gerrit-HasComments: No