You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2022/01/14 23:15:28 UTC

[GitHub] [guacamole-manual] necouchman commented on a change in pull request #180: GUACAMOLE-1501: Makefile: use `find` in a POSIX-compatible way.

necouchman commented on a change in pull request #180:
URL: https://github.com/apache/guacamole-manual/pull/180#discussion_r785222854



##########
File path: Makefile
##########
@@ -33,16 +33,16 @@ clean:
 	$(RM) -R build/
 
 # All files which the build depends on
-MD_FILES=$(shell find -path "./src/*" -name "*.md")
-RST_FILES=$(shell find -path "./src/*" -name "*.rst")
-PNG_FILES=$(shell find -path "./src/*" -name "*.png")
+MD_FILES=$(shell find ./src -name "*.md")
+RST_FILES=$(shell find ./src -name "*.rst")
+PNG_FILES=$(shell find ./src -name "*.png")

Review comment:
       Two concerns I have, here:
   1. Might still be good to quote the paths.
   2. Are there going to be any side effects to omitting the wildcard on the `src/*` path?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org