You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by "Madhan Neethiraj (JIRA)" <ji...@apache.org> on 2017/07/11 16:46:00 UTC

[jira] [Resolved] (ATLAS-1733) No SIGKILL in python signal library on Windows

     [ https://issues.apache.org/jira/browse/ATLAS-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Madhan Neethiraj resolved ATLAS-1733.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: 0.8.1-incubating
                   0.9-incubating

Thanks [~grahamwallis] for the fix; [~davidrad] for reviewing the patch.

Committed to the following branches:
 - master: http://git-wip-us.apache.org/repos/asf/incubator-atlas/commit/ad398393
 - 0.8-incubating: http://git-wip-us.apache.org/repos/asf/incubator-atlas/commit/13d5bfbf

> No SIGKILL in python signal library on Windows
> ----------------------------------------------
>
>                 Key: ATLAS-1733
>                 URL: https://issues.apache.org/jira/browse/ATLAS-1733
>             Project: Atlas
>          Issue Type: Bug
>          Components:  atlas-core
>    Affects Versions: 0.9-incubating
>         Environment: Windows 7
>            Reporter: Graham Wallis
>            Assignee: Graham Wallis
>            Priority: Minor
>             Fix For: 0.9-incubating, 0.8.1-incubating
>
>         Attachments: ATLAS-1733.patch, ATLAS-1733.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> [I am new to Atlas and this is my first JIRA issue so apologies if I have omitted any necessary information or steps.]
> There is no SIGKILL signal in the python signal library on Windows, so the import in atlas_stop.py fails.
> There are two ways I can suggest that we fix it:
> 1) introduce platform-specific code into atlas_stop.py
> 2) wrap the python os.kill function
> My preference is for the former as it is a small and localized change. 
> In either case the use of SIGTERM should be sufficient on Windows, as the existing python os.kill() function will open the process and terminate it, which is supposed to be equivalent to a SIGKILL (-9) on Linux.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)