You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/12/20 06:35:16 UTC
Re: Review Request: Fixed os read / write calls to be POSIX compliant
(handle 0, EINTR, and partial reads / writes).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8694/
-----------------------------------------------------------
(Updated Dec. 20, 2012, 5:35 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Fixed summary.
Summary (updated)
-----------------
Fixed os read / write calls to be POSIX compliant (handle 0, EINTR, and partial reads / writes).
Description
-------
All is well in the world again.
This bug manifested when I was fixing MESOS-326.
This addresses bug MESOS-319.
https://issues.apache.org/jira/browse/MESOS-319
Diffs
-----
src/master/master.cpp fbf7f0775392e3d21a6986203ed8f11729ffda8c
src/slave/state.cpp 4d4c2470c44fe630ec0694ee937131b4f0aafc4e
src/tests/stout_tests.cpp efdb47f1d2401f9175a05fc65922d9ab7e383666
third_party/libprocess/include/stout/os.hpp 76e5e0624af36a0021755fb4acf7f76bfb81a823
Diff: https://reviews.apache.org/r/8694/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Fixed os read / write calls to be POSIX compliant
(handle 0, EINTR, and partial reads / writes).
Posted by Vinod Kone <vi...@gmail.com>.
> On Jan. 30, 2013, 7:54 p.m., Benjamin Hindman wrote:
> > src/master/master.cpp, lines 90-91
> > <https://reviews.apache.org/r/8694/diff/2/?file=248641#file248641line90>
> >
> > By our objective and irrefutable assessment metric known as "jaggedness", I argue the original formatting was better! ;)
compared to below, this is not objective at all :)
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8694/#review15808
-----------------------------------------------------------
On Jan. 16, 2013, 12:48 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8694/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2013, 12:48 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> All is well in the world again.
> This bug manifested when I was fixing MESOS-326.
>
>
> This addresses bug MESOS-319.
> https://issues.apache.org/jira/browse/MESOS-319
>
>
> Diffs
> -----
>
> src/master/master.cpp fbf7f0775392e3d21a6986203ed8f11729ffda8c
> src/slave/state.cpp 4d4c2470c44fe630ec0694ee937131b4f0aafc4e
> src/tests/stout_tests.cpp c352066f60a68208397651d887da40cbd5fc37f3
> third_party/libprocess/include/stout/os.hpp 5b5b33636cb396c3324ab7f3f42144f4ab30ef95
>
> Diff: https://reviews.apache.org/r/8694/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed os read / write calls to be POSIX compliant
(handle 0, EINTR, and partial reads / writes).
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8694/#review15808
-----------------------------------------------------------
Ship it!
src/master/master.cpp
<https://reviews.apache.org/r/8694/#comment34049>
By our objective and irrefutable assessment metric known as "jaggedness", I argue the original formatting was better! ;)
src/master/master.cpp
<https://reviews.apache.org/r/8694/#comment34050>
I like this one better though!
third_party/libprocess/include/stout/os.hpp
<https://reviews.apache.org/r/8694/#comment34052>
It's unclear whether or not we'll always be able to restore the offset, so we probably shouldn't expose the semantics as such so people don't expect it.
- Benjamin Hindman
On Jan. 16, 2013, 12:48 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8694/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2013, 12:48 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> All is well in the world again.
> This bug manifested when I was fixing MESOS-326.
>
>
> This addresses bug MESOS-319.
> https://issues.apache.org/jira/browse/MESOS-319
>
>
> Diffs
> -----
>
> src/master/master.cpp fbf7f0775392e3d21a6986203ed8f11729ffda8c
> src/slave/state.cpp 4d4c2470c44fe630ec0694ee937131b4f0aafc4e
> src/tests/stout_tests.cpp c352066f60a68208397651d887da40cbd5fc37f3
> third_party/libprocess/include/stout/os.hpp 5b5b33636cb396c3324ab7f3f42144f4ab30ef95
>
> Diff: https://reviews.apache.org/r/8694/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed os read / write calls to be POSIX compliant
(handle 0, EINTR, and partial reads / writes).
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8694/
-----------------------------------------------------------
(Updated Jan. 16, 2013, 12:48 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Rebased off trunk.
Description
-------
All is well in the world again.
This bug manifested when I was fixing MESOS-326.
This addresses bug MESOS-319.
https://issues.apache.org/jira/browse/MESOS-319
Diffs (updated)
-----
src/master/master.cpp fbf7f0775392e3d21a6986203ed8f11729ffda8c
src/slave/state.cpp 4d4c2470c44fe630ec0694ee937131b4f0aafc4e
src/tests/stout_tests.cpp c352066f60a68208397651d887da40cbd5fc37f3
third_party/libprocess/include/stout/os.hpp 5b5b33636cb396c3324ab7f3f42144f4ab30ef95
Diff: https://reviews.apache.org/r/8694/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Fixed os read / write calls to be POSIX compliant
(handle 0, EINTR, and partial reads / writes).
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8694/#review15051
-----------------------------------------------------------
Ship it!
thank you
- Vinod Kone
On Dec. 20, 2012, 5:35 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8694/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2012, 5:35 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> All is well in the world again.
> This bug manifested when I was fixing MESOS-326.
>
>
> This addresses bug MESOS-319.
> https://issues.apache.org/jira/browse/MESOS-319
>
>
> Diffs
> -----
>
> src/master/master.cpp fbf7f0775392e3d21a6986203ed8f11729ffda8c
> src/slave/state.cpp 4d4c2470c44fe630ec0694ee937131b4f0aafc4e
> src/tests/stout_tests.cpp efdb47f1d2401f9175a05fc65922d9ab7e383666
> third_party/libprocess/include/stout/os.hpp 76e5e0624af36a0021755fb4acf7f76bfb81a823
>
> Diff: https://reviews.apache.org/r/8694/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>