You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/27 21:55:23 UTC

[GitHub] seelmann commented on a change in pull request #4600: [AIRFLOW-3765] Fix for create/update xcom values using the admin UI

seelmann commented on a change in pull request #4600: [AIRFLOW-3765] Fix for create/update xcom values using the admin UI
URL: https://github.com/apache/airflow/pull/4600#discussion_r251257161
 
 

 ##########
 File path: airflow/models/__init__.py
 ##########
 @@ -188,6 +188,55 @@ def get_fernet():
     return _fernet
 
 
+class XComSerializer(types.TypeDecorator):
 
 Review comment:
   I'd suggest to directly move this new class out into it's own file?
   See discussion https://lists.apache.org/thread.html/3c15a871b15f99b4dd4bef25085b4de1c167c728f08262df73ef7217@%3Cdev.airflow.apache.org%3E

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services