You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "peterxcli (via GitHub)" <gi...@apache.org> on 2025/02/20 08:46:21 UTC

[PR] HDDS-12371 Duplicated key scanning on multipartInfo table when listing multipart uploads [ozone]

peterxcli opened a new pull request, #7937:
URL: https://github.com/apache/ozone/pull/7937

   ## What changes were proposed in this pull request?
   
   Duplicate key scanning in `keyManagerImpl#listMultipartUploads` and `OmMetadataManagerImpl#getMultipartUploadKeys`
   
   we can change `OmMetadataManagerIMpl#getMultipartUploadKeys` to `OmMetadataManagerIMpl#listMultipartUploads` that returns `List<OmMultipartUpload>` (`OmMetadataManagerImpl` only takes care of simple OM DB operations), and the `KeyManagerImpl#listMultipartUploads` will be in charge of setting the `nextKeyMarker`, `nextUploadId`, and `isTruncated`, finally converting it to `OmMultipartUploadList`.
   
   Then we can also remove the `MultipartUploadKeys` class.
   
   https://github.com/apache/ozone/pull/7817#discussion_r1957672527
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-12371
   
   ## How was this patch tested?
   
   existing tests
   
   CI:
   https://github.com/peterxcli/ozone/actions/runs/13431235258


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-12371. Duplicated key scanning on multipartInfo table when listing multipart uploads [ozone]

Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 merged PR #7937:
URL: https://github.com/apache/ozone/pull/7937


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-12371. Duplicated key scanning on multipartInfo table when listing multipart uploads [ozone]

Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on PR #7937:
URL: https://github.com/apache/ozone/pull/7937#issuecomment-2673257857

   @peterxcli Thanks for the improvement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-12371. Duplicated key scanning on multipartInfo table when listing multipart uploads [ozone]

Posted by "peterxcli (via GitHub)" <gi...@apache.org>.
peterxcli commented on PR #7937:
URL: https://github.com/apache/ozone/pull/7937#issuecomment-2673506543

   Thanks @ivandika3 for reviewing and merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

Re: [PR] HDDS-12371. Duplicated key scanning on multipartInfo table when listing multipart uploads [ozone]

Posted by "peterxcli (via GitHub)" <gi...@apache.org>.
peterxcli commented on PR #7937:
URL: https://github.com/apache/ozone/pull/7937#issuecomment-2671434559

   cc @ivandika3
   Please take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org