[GitHub] [iceberg] kbendick commented on a diff in pull request #5018: Core: Resolve environment variables in REST catalog config

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #5018:
URL: https://github.com/apache/iceberg/pull/5018#discussion_r895095138


##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -109,8 +110,11 @@ public RESTSessionCatalog() {
   }
 
   @Override
-  public void initialize(String name, Map<String, String> props) {
-    Preconditions.checkArgument(props != null, "Invalid configuration: null");
+  public void initialize(String name, Map<String, String> unresolved) {

Review Comment:
   Nit / non-blocking: What about `unresolvedProps` or maybe the standard `props` and then using `fullProps` or some combination?
   
   I don't love my ideas, but `unresolved` by itself is somewhat confusing for me. It initially reads as somehow more special than just the `properties` map (with or without env variable resolution applied).
   
   By the interface, it is `props` so I'm ok with it, but the name itself is a little misleading when reading it imo.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org