You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by "vlsi (via GitHub)" <gi...@apache.org> on 2023/06/15 19:40:18 UTC

[GitHub] [jmeter] vlsi opened a new pull request, #5987: fix: encode unicode characters in filenames when sending files in HTTP Sampler

vlsi opened a new pull request, #5987:
URL: https://github.com/apache/jmeter/pull/5987

   ## Description
   
   Use RFC 7578 for encoding filenames when uploading files in HTTP Sampler.
   HttpClient4 does not support filename encoding, so we encode it at JMeter side
   
   ## Motivation and Context
   
   See https://github.com/apache/jmeter/issues/4546
   
   ## How Has This Been Tested?
   
   See `ConversionUtilsTest`, `HttpSamplerTest`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] vlsi commented on pull request #5987: fix: encode unicode characters in filenames when sending files in HTTP Sampler

Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi commented on PR #5987:
URL: https://github.com/apache/jmeter/pull/5987#issuecomment-1597203521

   It looks like RFC 5987 is not the latest standard: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/network/form_data_encoder.cc;l=162-191;drc=4cd749d0d82138ff31ed3a2bc5d925bb6d83fe16, https://github.com/curl/curl/issues/7789#issuecomment-930138204
   
   > For field names and filenames for file fields, the result of the encoding in the previous bullet point must be escaped by replacing any 0x0A (LF) bytes with the byte sequence `%0A`, 0x0D (CR) with `%0D` and 0x22 (") with `%22`. The user agent must not perform any other escapes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] user412857 commented on pull request #5987: fix: encode unicode characters in filenames when sending files in HTTP Sampler

Posted by "user412857 (via GitHub)" <gi...@apache.org>.
user412857 commented on PR #5987:
URL: https://github.com/apache/jmeter/pull/5987#issuecomment-1597138181

   If I understand well the fix consists in systematically encode file name in UTF8. Wouldn't it be better to encode only if it contains special characters?
   How can the server know that the file name has been encoded?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] vlsi merged pull request #5987: fix: encode unicode characters in filenames when sending files in HTTP Sampler

Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi merged PR #5987:
URL: https://github.com/apache/jmeter/pull/5987


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org