You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/13 12:48:57 UTC

[GitHub] [pulsar] cbornet commented on a diff in pull request #10487: Add the Maven wrapper

cbornet commented on code in PR #10487:
URL: https://github.com/apache/pulsar/pull/10487#discussion_r872362910


##########
.mvn/wrapper/maven-wrapper.properties:
##########
@@ -0,0 +1,2 @@
+distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.1/apache-maven-3.8.1-bin.zip

Review Comment:
   done



##########
README.md:
##########
@@ -90,6 +90,9 @@ Requirements:
    * When building Pulsar on a higher version (higher than Java 8), the resulting artifacts are not compatible with Java 8 runtime because of some issues, such as [issue 8445](https://github.com/apache/pulsar/issues/8445).
  * Maven 3.6.1+
 
+> Note: this project includes a [Maven Wrapper](https://github.com/takari/maven-wrapper) that can be used instead of a system installed Maven.

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org