You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/11/06 13:21:39 UTC
[GitHub] [skywalking-java] kezhenxu94 commented on a change in pull request #55: add test case plugin on jdk17
kezhenxu94 commented on a change in pull request #55:
URL: https://github.com/apache/skywalking-java/pull/55#discussion_r744124704
##########
File path: .github/workflows/plugins-jdk14-test.0.yaml
##########
@@ -62,11 +62,13 @@ jobs:
- uses: actions/checkout@v2
with:
submodules: true
- - uses: actions/setup-java@v1
+ - uses: actions/setup-java@v2
with:
- java-version: 14
+ # temurin does not distribute non-lts version
+ distribution: 'zulu'
Review comment:
Why do you use these distribution instead of those that we are using in our official Docker images?
##########
File path: .github/workflows/plugins-jdk14-test.0.yaml
##########
@@ -62,11 +62,13 @@ jobs:
- uses: actions/checkout@v2
with:
submodules: true
- - uses: actions/setup-java@v1
+ - uses: actions/setup-java@v2
with:
- java-version: 14
+ # temurin does not distribute non-lts version
+ distribution: 'zulu'
Review comment:
Why do you use these distribution instead of those that we are using in our official Docker images?
Please use the same base images as what we are using in our official Docker images
##########
File path: .github/workflows/plugins-jdk14-test.0.yaml
##########
@@ -62,11 +62,13 @@ jobs:
- uses: actions/checkout@v2
with:
submodules: true
- - uses: actions/setup-java@v1
+ - uses: actions/setup-java@v2
with:
- java-version: 14
+ # temurin does not distribute non-lts version
+ distribution: 'zulu'
Review comment:
Why do you use these distribution instead of those that we are using in our official Docker images?
https://github.com/apache/skywalking-java/blob/02d6b9c2d85da2b1b1ce3e2a8013373e0e371ba1/Makefile#L44-L51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org