You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/09/22 16:18:05 UTC
[GitHub] [trafficcontrol] srijeet0406 opened a new issue #5060: Github actions Go Unit tests fail sometimes
srijeet0406 opened a new issue #5060:
URL: https://github.com/apache/trafficcontrol/issues/5060
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
- For *SUPPORT QUESTIONS*, use the
[Traffic Control slack channels](https://traffic-control-cdn.slack.com) or [Traffic Control mailing lists](http://trafficcontrol.apache.org/mailing_lists/).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR. -->
## I'm submitting a ...
<!-- delete all those that don't apply -->
<!--- security vulnerability (STOP!! - see above)-->
- bug report
<!--(Please do not submit support requests here - see above)-->
## Traffic Control components affected ...
<!-- delete all those that don't apply -->
- Traffic Control Client
- Traffic Monitor
- Traffic Ops
## Current behavior:
<!-- Describe how the bug manifests / how the current features are insufficient. -->
When you make a commit or create a PR, Github actions will run a set of tests on your code. The `Golang unit tests` task sometimes fails due to a couple of known culprits. Look here: https://github.com/srijeet0406/trafficcontrol/runs/1150200903
I haven't been able to reproduce this locally, but maybe if you run the test multiple times, it will eventually fail (because it seems like a race condition atm).
## Expected / new behavior:
<!-- Describe what the behavior would be without the bug / how the feature would improve Traffic Control -->
All github action tasks pass consistently.
## Minimal reproduction of the problem with instructions:
<!--
If the current behavior is a bug or you can illustrate your feature request better with an example,
please provide the *STEPS TO REPRODUCE* and include the applicable TC version.
-->
This happens intermittently. This is one example: https://github.com/srijeet0406/trafficcontrol/runs/1150200903
## Anything else:
<!-- e.g. stacktraces, related issues, suggestions how to fix -->
The two tests failing are:
`=== RUN TestGetImportProfileParameters/Fail:_Storage_error_selecting_param
TestGetImportProfileParameters/Fail:_Storage_error_selecting_param: profile_import_test.go:292: Starting test scenario: Fail: Storage error selecting param`
and
`=== RUN TestGetStats
TestGetStats: datareq_test.go:248: expected getStats TotalMemoryMB > 0, actual: '0'
--- FAIL: TestGetStats (0.01s)`
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on issue #5060: Github actions Go Unit tests fail sometimes
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on issue #5060:
URL: https://github.com/apache/trafficcontrol/issues/5060#issuecomment-696833240
Since these are 2 separate failing tests, would you please open a separate issue for one of them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on issue #5060: Github actions Go Unit tests fail sometimes (TestGetImportProfileParameters)
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #5060:
URL: https://github.com/apache/trafficcontrol/issues/5060#issuecomment-812090443
Is this still happening? I don't see it occurring in the actions but maybe they're just circumventing it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] srijeet0406 commented on issue #5060: Github actions Go Unit tests fail sometimes (TestGetImportProfileParameters)
Posted by GitBox <gi...@apache.org>.
srijeet0406 commented on issue #5060:
URL: https://github.com/apache/trafficcontrol/issues/5060#issuecomment-812135588
I haven't seen it in a long time now, closing this for now, will reopen if the issue reappears.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] srijeet0406 closed issue #5060: Github actions Go Unit tests fail sometimes (TestGetImportProfileParameters)
Posted by GitBox <gi...@apache.org>.
srijeet0406 closed issue #5060:
URL: https://github.com/apache/trafficcontrol/issues/5060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on issue #5060: Github actions Go Unit tests fail sometimes
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on issue #5060:
URL: https://github.com/apache/trafficcontrol/issues/5060#issuecomment-696833240
Since these are 2 separate failing tests, would you please open a separate issue for one of them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on issue #5060: Github actions Go Unit tests fail sometimes (TestGetImportProfileParameters)
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on issue #5060:
URL: https://github.com/apache/trafficcontrol/issues/5060#issuecomment-812093760
It succeeds 1000 out of 1000 times for me when testing locally.
```shell
cd traffic_ops/traffic_ops_golang/profile
go test -c
failures=0
for ((i = 0; i < 1000; i++)); do
./profile.test test.run TestGetImportProfileParameters || (( ++failures ))
done;
echo "Failed ${failures} times out of ${i}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org