You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2024/12/17 18:00:46 UTC
[Impala-ASF-CR] IMPALA-13619: Update commons-lang3 to 3.17.0
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22227
Change subject: IMPALA-13619: Update commons-lang3 to 3.17.0
......................................................................
IMPALA-13619: Update commons-lang3 to 3.17.0
Updates commons-lang3 to 3.17.0, and provides the
IMPALA_COMMONS_LANG3_VERSION environment variable to override the
version.
Change-Id: I4005f8aef1cf66a32840cd0b510cd7faf597f5f2
---
M bin/impala-config.sh
M java/pom.xml
2 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/22227/1
--
To view, visit http://gerrit.cloudera.org:8080/22227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4005f8aef1cf66a32840cd0b510cd7faf597f5f2
Gerrit-Change-Number: 22227
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-13619: Update commons-lang3 to 3.17.0
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22227 )
Change subject: IMPALA-13619: Update commons-lang3 to 3.17.0
......................................................................
Patch Set 2: Verified+1 Code-Review+2
Carry Joe's +1 and verified after commit message update.
--
To view, visit http://gerrit.cloudera.org:8080/22227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4005f8aef1cf66a32840cd0b510cd7faf597f5f2
Gerrit-Change-Number: 22227
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 18 Dec 2024 18:26:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13619: Update commons-lang3 to 3.17.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22227 )
Change subject: IMPALA-13619: Update commons-lang3 to 3.17.0
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/17711/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4005f8aef1cf66a32840cd0b510cd7faf597f5f2
Gerrit-Change-Number: 22227
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 17 Dec 2024 18:26:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13619: Update commons-lang3 to 3.17.0
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/22227 )
Change subject: IMPALA-13619: Update commons-lang3 to 3.17.0
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/22227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4005f8aef1cf66a32840cd0b510cd7faf597f5f2
Gerrit-Change-Number: 22227
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 18 Dec 2024 09:19:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13619: Update commons-lang3 to 3.17.0
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22227 )
Change subject: IMPALA-13619: Update commons-lang3 to 3.17.0
......................................................................
Patch Set 1: Code-Review+1
This looks good to me. I'm willing to go to +2
--
To view, visit http://gerrit.cloudera.org:8080/22227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4005f8aef1cf66a32840cd0b510cd7faf597f5f2
Gerrit-Change-Number: 22227
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 17 Dec 2024 18:26:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13619: Update commons-lang3 to 3.17.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22227 )
Change subject: IMPALA-13619: Update commons-lang3 to 3.17.0
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11218/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4005f8aef1cf66a32840cd0b510cd7faf597f5f2
Gerrit-Change-Number: 22227
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 17 Dec 2024 18:27:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13619: Update commons-lang3 to 3.17.0
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Peter Rozsa, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22227
to look at the new patch set (#2).
Change subject: IMPALA-13619: Update commons-lang3 to 3.17.0
......................................................................
IMPALA-13619: Update commons-lang3 to 3.17.0
Updates commons-lang3 - used by Thrift and Orc - to 3.17.0, and
provides the IMPALA_COMMONS_LANG3_VERSION environment variable to
override the version.
Change-Id: I4005f8aef1cf66a32840cd0b510cd7faf597f5f2
---
M bin/impala-config.sh
M java/pom.xml
2 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/22227/2
--
To view, visit http://gerrit.cloudera.org:8080/22227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4005f8aef1cf66a32840cd0b510cd7faf597f5f2
Gerrit-Change-Number: 22227
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-13619: Update commons-lang3 to 3.17.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22227 )
Change subject: IMPALA-13619: Update commons-lang3 to 3.17.0
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4005f8aef1cf66a32840cd0b510cd7faf597f5f2
Gerrit-Change-Number: 22227
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 17 Dec 2024 23:50:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13619: Update commons-lang3 to 3.17.0
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22227 )
Change subject: IMPALA-13619: Update commons-lang3 to 3.17.0
......................................................................
IMPALA-13619: Update commons-lang3 to 3.17.0
Updates commons-lang3 - used by Thrift and Orc - to 3.17.0, and
provides the IMPALA_COMMONS_LANG3_VERSION environment variable to
override the version.
Change-Id: I4005f8aef1cf66a32840cd0b510cd7faf597f5f2
Reviewed-on: http://gerrit.cloudera.org:8080/22227
Reviewed-by: Peter Rozsa <pr...@cloudera.com>
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M bin/impala-config.sh
M java/pom.xml
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Peter Rozsa: Looks good to me, but someone else must approve
Michael Smith: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4005f8aef1cf66a32840cd0b510cd7faf597f5f2
Gerrit-Change-Number: 22227
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>