You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "SachinS10-lab (via GitHub)" <gi...@apache.org> on 2024/08/02 09:05:08 UTC

[PR] [Improve][feature][Bug] Add Tooltip and Fix Design Issue In the Task Definition [seatunnel-web]

SachinS10-lab opened a new pull request, #171:
URL: https://github.com/apache/seatunnel-web/pull/171

   
   
   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ### [Bug]
   When screen height is reduced or more items added in the task synchronization definition sidebar, tiles are falls out of the task synchronization definition sidebar.
   
   <img width="1701" alt="Screenshot 2024-08-02 at 11 11 33 AM" src="https://github.com/user-attachments/assets/2b22508c-c808-440d-8046-6bd6d6f80cd2">
   
   
   
   ## Purpose of this pull request
   This PR aims to enhance user experience by improving navigation through the task synchronization process and Fixed the above mentioned bug.
   
   **Changes Introduced:**
       Tooltips for Task Tiles : Added tooltips to the Source, Sink, and Transform tiles in the task synchronization definition sidebar. The tooltips provide guidance on dragging and configuring the tiles.
       Bug Fix : Addressed a bug that affected the display of the sidebar when the screen height was reduced or when more items were added.
   
   **How It Works:**
       Hover Over Info Icon : When hovering over the Info icon added to the right side of the task synchronization definition sidebar tiles, a tooltip will appear with helpful instructions.
       After Dragging Tiles : When dragging Source, Sink, or Transform tiles onto the canvas and selecting them, hovering over the tile will display a tooltip with additional instructions.
   
   **Additional Notes:**
       This is my first pull request. I would appreciate any comments, suggestions, or advice to improve it.
       
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][feature][Bug] Add Tooltip and Fix Design Issue In the Task Definition [seatunnel-web]

Posted by "SachinS10-lab (via GitHub)" <gi...@apache.org>.
SachinS10-lab commented on PR #171:
URL: https://github.com/apache/seatunnel-web/pull/171#issuecomment-2283219560

   @arshadmohammad. Sorry for the delay. Is it really needed to remove one commit?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][feature][Bug] Add Tooltip and Fix Design Issue In the Task Definition [seatunnel-web]

Posted by "arshadmohammad (via GitHub)" <gi...@apache.org>.
arshadmohammad commented on PR #171:
URL: https://github.com/apache/seatunnel-web/pull/171#issuecomment-2274952592

   Thanks @SachinS10-lab for raising this PR. I will review it.
   Meanwhile can you please remove the extra commit from your PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][feature][Bug] Add Tooltip and Fix Design Issue In the Task Definition [seatunnel-web]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #171:
URL: https://github.com/apache/seatunnel-web/pull/171#issuecomment-2272666656

   cc @arshadmohammad 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][feature][Bug] Add Tooltip and Fix Design Issue In the Task Definition [seatunnel-web]

Posted by "SachinS10-lab (via GitHub)" <gi...@apache.org>.
SachinS10-lab commented on PR #171:
URL: https://github.com/apache/seatunnel-web/pull/171#issuecomment-2272787342

   Hi @Hisoka-X, I've merged from main. Could you please rerun the checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][feature][Bug] Add Tooltip and Fix Design Issue In the Task Definition [seatunnel-web]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #171:
URL: https://github.com/apache/seatunnel-web/pull/171#issuecomment-2283223760

   > @arshadmohammad. Sorry for the delay. Is it really needed to remove one commit?
   
   IMO, unnecessary. We will execute squash and merge when merge to dev.
   ![image](https://github.com/user-attachments/assets/57c5b56e-1411-4f54-837d-4d52d7cc37f2)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][feature][Bug] Add Tooltip and Fix Design Issue In the Task Definition [seatunnel-web]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #171:
URL: https://github.com/apache/seatunnel-web/pull/171#issuecomment-2272767045

   Please try merge from dev.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][feature][Bug] Add Tooltip and Fix Design Issue In the Task Definition [seatunnel-web]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #171:
URL: https://github.com/apache/seatunnel-web/pull/171#issuecomment-2275018489

   cc @baicie
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][feature][Bug] Add Tooltip and Fix Design Issue In the Task Definition [seatunnel-web]

Posted by "SachinS10-lab (via GitHub)" <gi...@apache.org>.
SachinS10-lab commented on PR #171:
URL: https://github.com/apache/seatunnel-web/pull/171#issuecomment-2272761672

   Hi @Hisoka-X,
   I'm unable to address this Issue. Could please explain what is happening? How Can I Overcome this Issue?
   
   
   cc @arshadmohammad 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][feature][Bug] Add Tooltip and Fix Design Issue In the Task Definition [seatunnel-web]

Posted by "SachinS10-lab (via GitHub)" <gi...@apache.org>.
SachinS10-lab commented on PR #171:
URL: https://github.com/apache/seatunnel-web/pull/171#issuecomment-2273049805

   Thanks @Hisoka-X 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][feature][Bug] Add Tooltip and Fix Design Issue In the Task Definition [seatunnel-web]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X merged PR #171:
URL: https://github.com/apache/seatunnel-web/pull/171


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org